@tus/server: Metadata on namingFunction + propagate error #558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
716dbaa to
3f7fd83
Compare
Collaborator
Author
|
@Murderlon i think it makes a lot of sense to also pass the parsed function namingFunction(req, metadata) {
if (!metadata) {
throw new Error('must provide metadata')
}
// validate metadata
return metadata.fileName
} |
3f7fd83 to
e73ed0c
Compare
Member
|
Sounds good 👍 We can add the |
Collaborator
Author
|
Done 🎉 |
90ae3c6 to
6b8bc90
Compare
Murderlon
approved these changes
Jan 17, 2024
Member
|
I'll do a release tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR simply allows error propagation in the namingFunction.
Currently, if an error is thrown from the
namingFunctionthe error is swallowed and a 500 error code is returned.This behavior is not ideal, in my use case I rely on the
metadatain order to create a valid uploadID.For this reason the
metadatais validated in the naming function. If some of the fields don't pass the validation instead of returning a 400 status code, the application returns a non-ideal 500