Optionally follow symlinks when specifying input files #851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
3 similar comments
|
|
|
|
|
|
Xophmeister
commented
Jan 24, 2025
6ac8dee to
8cf93f9
Compare
|
|
If you use `if cfg!(unix) ...` then, while the Unix branch in Windows is unreachable, the linter still complains that Metadata.nlink isn't a valid method.
If the traversed file is not a directory (symlinked or otherwise), _only_ handle it if it's a regular file
nbacquey
approved these changes
Jan 28, 2025
Member
nbacquey
left a comment
There was a problem hiding this comment.
LGTM except for the small remark. Thanks @Xophmeister!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optionally follow (and resolve) symlinks when specifying input files
Resolves #834
Description
Provides an
-L/--follow-symlinksoption totopiary formatwhich will follow and resolve symlinks when computing the set of input files. If this CLI option is specified, then the filesystem traversal:The deduplication now happens after the traversal, rather than before, to dedup symlinks that point to files that exist within the input file set. (This means that if you do, say,
topiary format directory directory, then it will do twice as much work before dedup'ing, but that's an edge case that's not worth worrying about.)Checklist
Checklist before merging: