-
Notifications
You must be signed in to change notification settings - Fork 47
chore: Use official grammar repo for OpenSCAD #896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Xophmeister should I avoid manually updating |
|
Seems there's compatibility issues: https://github.com/tweag/topiary/actions/runs/13704201091/job/38325408688?pr=896#step:9:618 |
It's fine to update it outside of the automation we now have 👍 In fact, it's probably necessary for the CI to run on this PR.
Have the grammars changed between your version and this official version? I haven't looked into them, but that's the only thing I can think of (not that much has happened since your original OpenSCAD contribution was merged). |
Yes it looks like tree-sitter 0.25 was a breaking change in the ABI:
|
52be462 to
8e4230e
Compare
|
Apologies: I messed up the merge conflict, so rebased and tried again... I will approve this, once the tests have passed 👍 but please double-check I haven't messed it up again, before you merge 😅 |
|
@Xophmeister everything LGTM! |
Use official grammar repo for OpenSCAD
References Leathong/openscad-LSP#35
Description
tree-sitter-openscad has moved to the https://github.com/openscad org where the NPM package, crate, and python lib are pushed from. This PR updates the grammar location in
languages.nclandflake.nixto point to https://github.com/openscad/tree-sitter-openscad/Checklist
Checklist before merging, wherever relevant:
CHANGELOG.mdupdatedREADME.mdup-to-date