fix(http-ratelimiting): filter removed queues in actor gc #2490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erk-
approved these changes
Dec 13, 2025
Erk-
reviewed
Dec 13, 2025
Comment on lines
+181
to
+182
| // Already removed. | ||
| Err(_) => false, |
Member
There was a problem hiding this comment.
Should we add a debug log here as well?
Member
Author
There was a problem hiding this comment.
I don't think so, it'd add too much noise and would rather belong at the trace level
HTGAzureX1212
approved these changes
Dec 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple buckets may point to the same queue.
See user bug report: https://discord.com/channels/745809834183753828/1448906238762156225