[SDK Renaming] - New Carthage Version & Adjustments #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update danger * Add @AlejandroOrozco as contributor
Version 0.4.1
- Remove team's placeholderID.
…aceHolderIDs [Xcode 12 Migration] - Remove team's placeholderID.
- Remove team's placeholderID.
…aceHolderIDs [Xcode 12 Migration] - Remove team's placeholderID.
- Quick adjustments to SDK zip framework & Update Readme with Carthage instructions.
…obuiles/SDK-Renaming/NewCarthageVersion
838bf52 to
0e302d3
Compare
yafuquen
reviewed
May 19, 2021
README.md
Outdated
| 2. Build it from source (Not recommended), this is the opted option for Carthage when it is unable to find a raw `.framework`, Carthage will be slicing the iPhone-Simulator arm64 version to create a fat framework using Xcode 12, so it will work on all devices except the Simulators running in a Mac with the SoC M1. | ||
| - This will require using the script to strip the framework's architecture before lipo command fails: https://github.com/Carthage/Carthage/blob/master/Documentation/Xcode12Workaround.md#workaround-script | ||
| - Also make sure to exclude the **arm64** architectures from your targets at **Built Settings** > **Architectures** > Exclude from **Any iOS Simulator SDK** > **arm64** | ||
| Since version `1.0.0` of `TwilioVerifySDK` the prebuilt asset fat version `.framework` is been deprecated, to give space for the universal framework `.xcframework`. Make sure to use the new version of Carthage [0.38.0](https://github.com/Carthage/Carthage/pull/3152) that was release in order to support the `xcframework` assets, by using this version or a superior one, Carthage will download and unzip the `TwilioVerifySDK.framework.zip` attached in the release version, resulting in a `TwilioVerifySDK.xcframework` that can be found in the build folder of Carthage. |
There was a problem hiding this comment.
It would be better to point to the release (https://github.com/Carthage/Carthage/releases/tag/0.38.0) instead of the PR (Carthage/Carthage#3152)
There was a problem hiding this comment.
That makes sense, Thank you. I just updated that reference 👍 .
0e302d3 to
6d64919
Compare
SergioFierro
approved these changes
May 24, 2021
yafuquen
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TwilioVerifySDK.framework.zipto complain the requirements of Carthage.Commit message
Screenshot
Testing