Skip to content

Fix config Writing#8

Merged
Andrew-Kulpa merged 2 commits into
mainfrom
fix_config
Jan 21, 2022
Merged

Fix config Writing#8
Andrew-Kulpa merged 2 commits into
mainfrom
fix_config

Conversation

@Andrew-Kulpa

@Andrew-Kulpa Andrew-Kulpa commented Jan 21, 2022

Copy link
Copy Markdown

Description

  • Adds error checking for failed config writing
  • Fixes previous writing of token to a utils.GetConfigPath instead of utils.GetConfigFile

image

@Andrew-Kulpa Andrew-Kulpa self-assigned this Jan 21, 2022
fantasticrabbit
fantasticrabbit approved these changes Jan 21, 2022
View reviewed changes

@fantasticrabbit fantasticrabbit left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, built local and tested, auth functionality is fixed.

artur-sak13
artur-sak13 approved these changes Jan 21, 2022
View reviewed changes

@artur-sak13 artur-sak13 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Andrew-Kulpa Andrew-Kulpa merged commit 6a39281 into main Jan 21, 2022
@Andrew-Kulpa Andrew-Kulpa deleted the fix_config branch January 21, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artur-sak13 artur-sak13 artur-sak13 approved these changes

+1 more reviewer

@fantasticrabbit fantasticrabbit fantasticrabbit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Andrew-Kulpa Andrew-Kulpa

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Andrew-Kulpa @artur-sak13 @fantasticrabbit