Skip to content

Add Hash and Order Instances for NonEmptyVector #4612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 10, 2024
Merged

Add Hash and Order Instances for NonEmptyVector #4612

merged 3 commits into from
Jun 10, 2024

Conversation

@isomarcte
Copy link
Member

@isomarcte isomarcte commented Jun 6, 2024

No description provided.

rossabaker
rossabaker reviewed Jun 6, 2024
View reviewed changes
Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're in this part of the hierarchy, does PartialOrder make sense?

@rossabaker
Copy link
Member

rossabaker commented Jun 6, 2024

Reran the nuisance native failure.

@isomarcte
Copy link
Member Author

isomarcte commented Jun 6, 2024

While we're in this part of the hierarchy, does PartialOrder make sense?

@rossabaker added

@isomarcte isomarcte requested a review from rossabaker June 6, 2024 20:50
@rossabaker
Copy link
Member

rossabaker commented Jun 6, 2024

I think this works, but while we wait for CI: in Chain, PartialOrder is higher priority than Hash. Here, that relative order is flipped. I don't think it matters between this pair, but we're leaving the comfortable precedent of Chain.

@isomarcte
Copy link
Member Author

isomarcte commented Jun 10, 2024

@rossabaker updated to match the Chain priority.

satorg
satorg approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@satorg satorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rossabaker rossabaker merged commit 90db3cd into typelevel:main Jun 10, 2024
@isomarcte isomarcte deleted the non-empty-vector-order branch June 11, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rossabaker rossabaker rossabaker approved these changes

@satorg satorg satorg approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@isomarcte @rossabaker @satorg