Skip to content

Conversation

@Ivan091
Copy link
Contributor

@Ivan091 Ivan091 commented Nov 12, 2024

Thanks for opening a PR!

If the CI build fails due to Scalafmt, run sbt scalafmtAll and push the changes (generally a good idea to run this prior to opening the PR).

It's also helpful to run sbt prePR, which runs tests, generates docs, and performs various checks.

Feel free to ask questions on the fs2 and fs2-dev channels on the Typelevel Discord server.

@Ivan091 Ivan091 force-pushed the add-evalFold branch 2 times, most recently from a0c19cc to 2f432d4 Compare November 12, 2024 09:03
@Ivan091
Copy link
Contributor Author

Ivan091 commented Nov 12, 2024

Hi guys, my first PR ever to an Open Source lib.
Once in a while, I need this evalFold method, it's annoying we don't have it yet.
As a workaround I've been using evalMapAccumulate; though, it's not elegant

@Ivan091 Ivan091 changed the title add evalFold combinator to Stream Add evalFold combinator to Stream Nov 12, 2024
@mpilquist
Copy link
Member

Awesome, thanks for contributing & congrats on your first PR to open source! Much appreciated!

@mpilquist mpilquist merged commit ad25f4f into typelevel:main Nov 19, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants