-
Notifications
You must be signed in to change notification settings - Fork 621
Unify TCP/UDP and UnixSocket APIs #3563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpilquist
commented
Apr 8, 2025
armanbilge
reviewed
Apr 10, 2025
|
Going to merge this one this week unless there's any objections. |
… fromKeyStoreResource
…n various platforms
…dshake to peg a server cpu
Fix spinloop bug in TLSEngine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3560
This PR revamps
fs2.io.netin a number of significant ways:connectfor clients andbindfor servers, both taking the newcom.comcast.ip4s.GenSocketAddresstype, which is a supertype ofSocketAddress[Host]andUnixSocketAddressSocketGroup- there has never really been a great reason to manage explicit thread pools / async socket groups & the API was JVM only. With the new polling system, there's even less of a reason to ever use the explicitly managed socket groups.UnixSocketsas there's no utility provided that's not also provided byNetworknowclient,server,serverResourcein favor ofconnect,bindAndAccept,bindServerSocket, which provides the bound address of the server socket, access to options, and a stream of client sockets.SocketInfoas a supertype ofSocketandServerSocket.address: GenSocketAddressonSocketInfoandpeerAddress: GenSocketAddressonSocket, replacinglocalAddressandremoteAddress(each of typeF[SocketAddress[IpAddress]].isOpenonSocketwhich is a vestige from when there was aclosemethod.Datagram sockets have been similarly revamped:
openDatagramSockethas been replaced withbindDatagramSocket, taking aGenSocketAddressUpdates to downstream projects: