Fix unnecessary disambiguation around ibids #250
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
These tests also fail on main currently, so I think this has nothing to do with my changes? |
Contributor
Author
|
@tsteckenborn Could you confirm this also fixes your issue or could you provide the files that caused this for you? |
Contributor
Are you sure? I'd expect archive tests to fail as archive tests just compare the existing archive files with upstream CSL styles, but no citeproc tests are failing on main (at least, the CI check is green). Your PR might have triggered some unintended side-effects (would need further investigation). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #129.
Disambiguation currently compares the normal render of a citation. This means that if two different citations both render to "ibid", they are disambiguated without actually being ambiguous. This PR solves that by creating a second render that disables ibids and using that for comparison.
Example:
bibliography.yaml
Faulty render without this PR
Correct render with this PR
