Skip to content

Conversation

@Drodt
Copy link
Contributor

@Drodt Drodt commented Aug 13, 2025

Fixes new compiler warnings of hidden lifetimes. Also uses explicitly the OptionExt trait to prepare for new std functionality.

@laurmaedje
Copy link
Member

Our utils impl and std do the same thing, so I wonder whether it's necessary to do this. I would've hoped that we can just get the std impl and then remove the polyfill trait some way down the road when the MSRV allows for it.

@Drodt
Copy link
Contributor Author

Drodt commented Aug 15, 2025

So you want to leave the warnings until these functions are stabilized?

@laurmaedje
Copy link
Member

We could just silence the warnings. Or do you think it's a bad idea?

It feels a bit unnecessary to me to change to fully qualified calls and then switch back to the exact previous code.

@Drodt
Copy link
Contributor Author

Drodt commented Aug 16, 2025

I changed it as you wished

@laurmaedje
Copy link
Member

Thanks! I folded this into #6775 to make sure we don't accumulate new warnings before bumping.

@laurmaedje laurmaedje closed this Aug 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants