Error for overflowing integer literals#8448
Open
isuffix wants to merge 2 commits into
Open
Conversation
354bd5e to
74af696
Compare
632da30 to
c5672df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the more constrained of two followup PRs for #8445 based on discussion from #7389. Only the last two commits are unique.
This PR causes us to error for overflowing integer literals instead of treating them as floats. However, we only error during evaluation so that we still highlight invalid integer literals as integers.
I have included tests for this highlighting behavior and that we don't error if the integer value isn't evaluated.
I have also finally added a
NonDecimalBaseenum to make our non-decimal handling more semantic.And I've added a more complete description of our integer syntax to the docs.