Various crash fixes and cleanups #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix this warning when a dataset contains an x-value of 0:
Warning: Error in if: missing value where TRUE/FALSE needed
and this other one when the zero x-value is removed, because zlim may not
have been updated:
Warning: Error in : [plot_AbanicoPlot()] 'zlim' should only contain
positive values when 'log.z = TRUE'
This was a regression from 38341c6.
This was a regression from 23586f0.
The numericInput control allowed the user to set values outside the 0-1 range, thus causing validation errors in calc_AliquotSize().
This avoids displaying unused columns in the UI.
Those values have been set just a few lines above, so the checks will always be true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of various commits to fix crashes when loading CSV files of the wrong size, and other crashes caused by more stringent validation in the master Luminescence.