Skip to content

add-Num#bigDecimalValue #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TheCookieLab merged 1 commit into from
Jul 6, 2024
Merged

add-Num#bigDecimalValue #1109

TheCookieLab merged 1 commit into from
Jul 6, 2024

Conversation

@nimo23
Copy link
Contributor

@nimo23 nimo23 commented Sep 4, 2023 •
edited
Loading

Fixes #.

Changes proposed in this pull request:

  • added Num.bigDecimalValue() to convert the Num to a BigDecimal

    • For DecimalNum it returns its delegate
    • For DoubleNum it converts by BigDecimal.valueOf(delegate) (if delegate is NaN or Infinity, then it simply returns null)
    • For NaN it simply returns null.

  • added an entry with related ticket number(s) to the unreleased section of CHANGES.md

Actually, it's not easy to get the BigDecimal-representation of a Num. We have intValue(), longValue(), doubleValue(), etc. so it also makes sense to add bigDecimalValue().

@nimo23
Copy link
Contributor Author

nimo23 commented Sep 4, 2023 •
edited
Loading

Would it be better to overwrite bigDecimalValue() in its subclasses instead of providing a default method?

For example, in DecimalNum:

 @Override
 public BigDecimal bigDecimalValue() {
        return delegate;
}

With this, no if and cast is needed..

@TheCookieLab
Copy link
Member

TheCookieLab commented Nov 30, 2023

Would it be better to overwrite bigDecimalValue() in its subclasses instead of providing a default method?

For example, in DecimalNum:

 @Override
 public BigDecimal bigDecimalValue() {
        return delegate;
}

With this, no if and cast is needed..

Yes, that would be ideal.

TheCookieLab
TheCookieLab requested changes Jun 29, 2024
View reviewed changes
@TheCookieLab TheCookieLab merged commit 7e296de into ta4j:master Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheCookieLab TheCookieLab TheCookieLab approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nimo23 @TheCookieLab