You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR attempts to repair some of the broken variable names from the Bootstrap 5 transition somewhere between betas 16 and 19 (and now beta 20 as of this morning) and to improve the accessibility with a more visually consistent color-step palette.
(Apologies for my non-hi-DPI screen with which I took these screenshots...)
Border color on hover was black because of missing variable:
I restored the previous look by repairing the variable, which makes it a dark gray (which IMO looks better too -- this is the way it was in beta ~16):
Hover BGs are now visible, they got lost somewhere between beta 16 and 19. Now they're even more visible, but not too much.
Before:
Current:
After:
Restored the pre-beta-19 blue color, so that Tabler brand color is its own distinct color. This also improves contrast of buttons and links which are now more legible in dark mode.
Current:
After:
There's still some work to do which I may push to this PR if it's still open, but I think this PR is a good step forward and ready to go anyway.
(These visibility/accessibility improvements are required for my app, hence my PR. I'd love to not have to maintain a fork of Tabler, if it's possible I'd like to get this -- or something like this -- merged. 😊)
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
I'm still trying to figure out how to bring back the beta 16 navbar link hover colors. In dark mode, the links were gray but become white on hover. I can't seem to figure out how to make that happen in beta 20? Something -- I suspect Bootstrap -- is setting the alpha channel to 80% it seems.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to repair some of the broken variable names from the Bootstrap 5 transition somewhere between betas 16 and 19 (and now beta 20 as of this morning) and to improve the accessibility with a more visually consistent color-step palette.
(Apologies for my non-hi-DPI screen with which I took these screenshots...)
Border color on hover was black because of missing variable:
I restored the previous look by repairing the variable, which makes it a dark gray (which IMO looks better too -- this is the way it was in beta ~16):
Card caps bg is currently too hard to see:
Now it is visible again, closer to beta 16:
(Thus this PR fixes #1592)
It resolves a few accessibility issues as well:
Hover BGs are now visible, they got lost somewhere between beta 16 and 19. Now they're even more visible, but not too much.
Before:
Current:
After:
Restored the pre-beta-19 blue color, so that Tabler brand color is its own distinct color. This also improves contrast of buttons and links which are now more legible in dark mode.
Current:
After:
There's still some work to do which I may push to this PR if it's still open, but I think this PR is a good step forward and ready to go anyway.
(These visibility/accessibility improvements are required for my app, hence my PR. I'd love to not have to maintain a fork of Tabler, if it's possible I'd like to get this -- or something like this -- merged. 😊)