Update icons version and import script data path #2306
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@ethancrawford is attempting to deploy a commit to the Tabler Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
Author
|
😂 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not totally familiar with the process of importing the latest icons into Tabler core/preview, so @codecalm / @BG-Software-BG or other folks more familiar with the process, feel free to comment on anything that's not right - but I decided to test whether I could manually update https://github.com/tabler/tabler/blob/dev/shared/data/icons.json by running
preview/.build/import-icons.mjson the command line.At first, I encountered an error because the path here did not exist:
tabler/preview/.build/import-icons.mjs
Line 29 in e675389
(which in my case was returning):
Error: ENOENT: no such file or directory, open '/home/ethan/repos/tabler/preview/shared/data/icons-info.json'instead of generating the correct directory,
/home/ethan/repos/tabler/shared/data/icons-info.json.Once I updated the path on lines 29 and 38 of
/preview/.build/import-icons.mjs, the/shared/data/icons.jsonand/shared/data/icons-info.jsonfiles appeared to update successfully.I was intending to test whether updating
/shared/data/icons.jsonwould fix #2297 - however I'm also not sure how to view a local dev version of the documentation app - is this currently possible?