Allow Offcanvas docs page to scroll properly #2565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, The Offcanvas documentation examples were preventing the rest of the page from scrolling. This was easy enough to fix with a data attribute as per the Bootstrap documentation. However, it was also necessary to change the examples so that instead of forcing the Offcanvas elements into their 'visible' state with a hardcoded css class, they are triggered on page load with an inline javascript function.
|
|
@ethancrawford is attempting to deploy a commit to the Tabler Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, The Offcanvas documentation examples were preventing the rest of the page from scrolling. This was easy enough to fix with a data attribute as per the Bootstrap documentation. However, it was also necessary to change the examples so that instead of forcing the Offcanvas elements into their 'visible' state with a hardcoded css class, they are triggered on page load with an inline javascript function.
Fixes #2294.