fix(tom-select): override --bs- CSS vars with --tblr- equivalents#2644
Open
terminalchai wants to merge 1 commit into
Open
fix(tom-select): override --bs- CSS vars with --tblr- equivalents#2644terminalchai wants to merge 1 commit into
terminalchai wants to merge 1 commit into
Conversation
TomSelect's bootstrap5 preset stylesheet uses hardcoded --bs-* CSS custom properties (e.g. --bs-tertiary-bg, --bs-secondary-bg, --bs-body-bg). Tabler generates --tblr-* vars, so the --bs-* references are undefined at runtime, causing visible UI regressions. Most impactful: the active/highlighted dropdown option renders with no background because --bs-tertiary-bg is undefined. Add overrides in the TomSelect vendor SCSS for all affected selectors: - .ts-dropdown .active: use --tblr-active-bg (light primary tint) - .ts-dropdown .active.create: use --tblr-body-color - .ts-dropdown .optgroup-header: use --tblr-bg-surface + --tblr-body-color - .ts-wrapper.disabled .ts-control: use --tblr-secondary-bg - .ts-wrapper.full .ts-control: use --tblr-body-bg Fixes tabler#2600
|
|
@terminalchai is attempting to deploy a commit to the Tabler Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TomSelect ships a precompiled Bootstrap 5 CSS preset ( om-select.bootstrap5.css) that hardcodes --bs-* CSS custom properties — for example --bs-tertiary-bg, --bs-secondary-bg, --bs-body-bg. Tabler uses --tblr-* as its CSS variable prefix, so the Bootstrap-specific --bs-* names are undefined at runtime.
Closes #2600
Visible regression
The most impactful breakage: the active / highlighted dropdown option has no background because .ts-dropdown .active sets �ackground-color: var(--bs-tertiary-bg) which resolves to nothing:
css /* tom-select.bootstrap5.css — hardcoded --bs- names */ .ts-dropdown .active { background-color: var(--bs-tertiary-bg); } /* undefined in Tabler */ .ts-dropdown .optgroup-header { background: var(--bs-body-bg); } /* undefined */ .disabled .ts-control { background-color: var(--bs-secondary-bg); } /* undefined */ .full .ts-control { background-color: var(--bs-body-bg); } /* undefined */Fix
Add targeted overrides in core/scss/vendor/_tom-select.scss that replace each --bs-* reference with the Tabler equivalent using the \ SCSS variable:
All use the SCSS \ interpolation (�ar(--#{}...)) so they stay correct if the prefix ever changes.