Skip to content

Fixed the type of the ArgType #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tajo merged 2 commits into from
Sep 2, 2023
Merged

Fixed the type of the ArgType #441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0297535
Fixed the type of the ArgType
calloc134 May 30, 2023
18e46f2
Merge branch 'main' into fix/ArgType2
tajo Sep 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/kind-fans-smoke.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ladle/react": patch
---

Fixed the type of the "ArgType" object so that options are properly loaded into the type
2 changes: 1 addition & 1 deletion packages/ladle/lib/app/exports.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,6 @@ export type ControlType =
export interface ArgType<K = any> {
control?: {
name?: string;
options?: K[];
labels?: { [key: string]: string };
type: ControlType;
min?: number;
Expand All @@ -114,6 +113,7 @@ export interface ArgType<K = any> {
[key: string]: any;
};
mapping?: { [key: string | number]: any };
options?: K[] | unknown;
defaultValue?: K;
description?: string;
name?: string;
Expand Down
6 changes: 1 addition & 5 deletions type-tests/argTypes.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,7 @@ ArgTypes.argTypes = {
foo: {
control: {
type: "select",
options: [
"foo",
// @ts-expect-error - 1 is not a string
5,
],
options: ["foo", 5],
},
},
bar: {
Expand Down