Skip to content

Don't use CSS transform for sidebar chevrons #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tajo merged 1 commit into from
Sep 17, 2023
Merged

Don't use CSS transform for sidebar chevrons #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/angry-gorillas-train.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ladle/react": patch
---

Don't use CSS transform for sidebar chevrons so it doesn't create layering (stacking context) issues
21 changes: 14 additions & 7 deletions packages/ladle/lib/app/src/icons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,15 +133,22 @@ export const Down = ({ rotate }: { rotate?: boolean }) => {
<div
aria-hidden
style={{
width: "10px",
marginInlineEnd: "0.4em",
marginTop: "-0.1em",
transform: rotate ? "rotate(-90deg)" : undefined,
width: "16px",
marginInlineEnd: "0.1em",
marginBottom: "-0.1em",
}}
>
<svg fill="currentColor" viewBox="0 0 1024 574">
<path d="M1015 10q-10-10-23-10t-23 10L512 492 55 10Q45 0 32 0T9 10Q0 20 0 34t9 24l480 506q10 10 23 10t23-10l480-506q9-10 9-24t-9-24z" />
</svg>
{rotate ? (
<svg viewBox="0 0 24 24" stroke="currentColor" fill="none">
<path stroke="none" d="M0 0h24v24H0z" fill="none"></path>
<path d="M6 9l6 6l6 -6"></path>
</svg>
) : (
<svg viewBox="0 0 24 24" stroke="currentColor" fill="none">
<path stroke="none" d="M0 0h24v24H0z" fill="none"></path>
<path d="M9 6l6 6l-6 6"></path>
</svg>
)}
</div>
);
};
Expand Down