Skip to content

Load vite.config.ts the same way as Vite#162

Merged
tajo merged 4 commits into
tajo:masterfrom
kazuma1989:load-ts-vite-config
Jun 12, 2022
Merged

Load vite.config.ts the same way as Vite#162
tajo merged 4 commits into
tajo:masterfrom
kazuma1989:load-ts-vite-config

Conversation

@kazuma1989

@kazuma1989 kazuma1989 commented Jun 12, 2022

Copy link
Copy Markdown

Hi maintainers 👋
I would like to contribute to the great project!

I tried to follow the Contributing Guide.

WHAT the breaking change is

(Only for the package maintainers) a new E2E packages is added.

WHY the change was made

Ladle was not able to handle vite.config.ts the way Vite does.
For example, Ladle was not able to load vite.config.ts which imported other TS modules.

HOW a consumer should update their code

(Only for the package maintainers) recognize a new e2e workspace with pnpm install.

@changeset-bot

changeset-bot Bot commented Jun 12, 2022

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ff731f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
test-config-ts Major
@ladle/react Minor
example Patch
test-addons Patch
test-commonjs Patch
test-config Patch
test-css Patch
test-decorators Patch
test-flow Patch
test-programmatic Patch
test-provider Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Jun 12, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ladle ✅ Ready (Inspect) Visit Preview Jun 12, 2022 at 4:10PM (UTC)

@tajo tajo merged commit ff731f5 into tajo:master Jun 12, 2022
@tajo tajo mentioned this pull request Jun 12, 2022
@tajo

tajo commented Jun 12, 2022

Copy link
Copy Markdown
Owner

This is great. I completely missed the built-in Vite function. Thanks!

@kazuma1989 kazuma1989 deleted the load-ts-vite-config branch June 13, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants