fix: print usage when ccgate claude / ccgate codex runs on a tty#85
Merged
Conversation
Running the explicit forms in a terminal blocked on stdin, so any keystrokes (Ctrl-C, Ctrl-\, escape sequences) leaked into the JSON decoder and produced cryptic decode errors. The bare 'ccgate' invocation already detected a tty stdin and printed usage; extend the same guard to the explicit 'claude' and 'codex' hook commands. Fixes #80
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Running
ccgate codex(orccgate claude) directly in an interactiveterminal blocked on stdin while trying to JSON-decode it as a
PermissionRequest hook payload. Any keystrokes the user typed —
Ctrl-C,Ctrl-\, escape sequences — leaked into the decoder andproduced cryptic errors like:
Bare
ccgatealready handled this case: tty stdin → print usage,piped stdin → run the hook. The explicit
claude/codexformsskipped that guard and went straight into the decoder.
Fixes #80
What
isTerminal(stdin)check to theclaudeandcodexdispatch branches.versionthroughdispatchso it can callprintUsage.