Simplify scrolling code #2048
Open
Simplify scrolling code #2048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
nriley
reviewed
Oct 18, 2025
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
nriley
requested changes
Oct 25, 2025
plugin/mouse/mouse_scroll.py
Outdated
| __slots__ = ("_scroll_dir", "_is_vertical", "_direction_constant") | ||
|
|
||
| def __init__(self): | ||
| self._scroll_dir: Literal[-1, 1] = 1 |
Collaborator
There was a problem hiding this comment.
Would recommend that you just call set_direction here.
plugin/mouse/mouse_scroll.py
Outdated
| RIGHT = auto() | ||
|
|
||
|
|
||
| class ScrollingDirection: |
Collaborator
There was a problem hiding this comment.
Suggested change
| class ScrollingDirection: | |
| class Scroller: |
then this will free up ScrollingDirection for the enum.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
nriley
approved these changes
Oct 25, 2025
Collaborator
|
From the community backlog session — code looks in good shape, but we would like some additional testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the continuous scrolling code with better state management.