Skip to content

Fix UtilpIsCanonicalFormAddress #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tandasat merged 1 commit into from
Nov 25, 2021
Merged

Fix UtilpIsCanonicalFormAddress #86

tandasat merged 1 commit into from
Nov 25, 2021

Conversation

@kkent030315
Copy link
Contributor

@kkent030315 kkent030315 commented Nov 25, 2021 •
edited
Loading

UtilIsInBounds is weirdly used in UtilpIsCanonicalFormAddress which is referenced at UtilIsAccessibleAddress will resulted in UtilIsAccessibleAddress always FALSE.

HyperPlatform/HyperPlatform/util.cpp

Lines 572 to 579 in bf6a2b8

_Use_decl_annotations_ static bool UtilpIsCanonicalFormAddress(void *address) {
if (!IsX64()) {
return true;
} else {
return !UtilIsInBounds(0x0000800000000000ull, 0xffff7fffffffffffull,
reinterpret_cast<ULONG64>(address));
}
}

was evaluated as:

(0xffff7fffffffffffull <= 0x0000800000000000ull)
&&
(0x0000800000000000ull <= address);

Let me know if anything wrong with my interpret of the canonical address. :)
(I thought it was intentional use?)

@tandasat tandasat merged commit 85eaacb into tandasat:master Nov 25, 2021
@tandasat
Copy link
Owner

tandasat commented Nov 25, 2021

Nice catch, and thanks for the PR. Merged it.

@kkent030315 kkent030315 deleted the fix_UtilpIsCanonicalFormAddress branch November 26, 2021 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kkent030315 @tandasat