Skip to content

ui/users: create user dialog#1536

Merged
dctalbot merged 26 commits into
masterfrom
create-user
May 20, 2021
Merged

ui/users: create user dialog#1536
dctalbot merged 26 commits into
masterfrom
create-user

Conversation

@dctalbot
Copy link
Copy Markdown
Contributor

@dctalbot dctalbot commented May 13, 2021 •
edited
Loading

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Currently, goalert admins can only create users for basic auth via the CLI. This PR brings that functionality into the UI.

Part of #1247

Screenshots:
Screen Shot 2021-05-18 at 8 30 17 AM

Screen Shot 2021-05-17 at 5 20 31 PM

Describe any introduced user-facing changes:
Admins will have a create user fab on the users list page

Describe any introduced API changes:

  createUser(input: CreateUserInput!): User

input CreateUserInput {
  username: String!
  password: String!
  name: String
  email: String
  role: UserRole
}

Additional Info:

  • This functionality may move into a central user management page in the future

@mastercactapus
Copy link
Copy Markdown
Member

mastercactapus commented May 13, 2021

A couple of initial thoughts:

  • For role, maybe just an Admin checkmark in the dialog to replicate the --admin flag in CLI rather than making it a multi-step process
  • Still allow creating a user if Basic auth is disabled, but add a notice to the dialog that they will be unable to login until it's turned on

Lanithane
Lanithane suggested changes May 17, 2021
View reviewed changes
Comment thread web/src/app/users/UserCreateDialog.tsx Outdated
Comment thread web/src/app/users/UserCreateDialog.tsx Outdated
Comment thread web/src/app/users/UserCreateDialog.tsx Outdated
Comment thread web/src/app/users/UserCreateDialog.tsx Outdated
Comment thread web/src/app/users/UserCreateDialog.tsx Outdated
Comment thread web/src/app/users/UserCreateDialog.tsx
Comment thread web/src/app/users/UserCreateDialog.tsx
Comment thread web/src/app/users/UserCreateDialog.tsx
Lanithane
Lanithane reviewed May 17, 2021
View reviewed changes
Comment thread web/src/app/lists/QueryList.tsx
dctalbot and others added 7 commits May 17, 2021 15:53
@dctalbot @Lanithane
Update web/src/app/users/UserCreateDialog.tsx
f8a5703 
Co-authored-by: Nathaniel Cook <NathanielJCook@outlook.com>
@dctalbot @Lanithane
Update web/src/app/users/UserCreateDialog.tsx
dd713ef 
Co-authored-by: Nathaniel Cook <NathanielJCook@outlook.com>
@dctalbot @Lanithane
Update web/src/app/users/UserCreateDialog.tsx
4d995e0 
Co-authored-by: Nathaniel Cook <NathanielJCook@outlook.com>
@dctalbot @Lanithane
Update web/src/app/users/UserCreateDialog.tsx
75e1161 
Co-authored-by: Nathaniel Cook <NathanielJCook@outlook.com>
@dctalbot @Lanithane
Update web/src/app/users/UserCreateDialog.tsx
1857602 
Co-authored-by: Nathaniel Cook <NathanielJCook@outlook.com>
@dctalbot @Lanithane
Update web/src/app/users/UserCreateDialog.tsx
e3c10b2 
Co-authored-by: Nathaniel Cook <NathanielJCook@outlook.com>
@dctalbot
confirm pw field
731a07b
@dctalbot dctalbot requested a review from Lanithane May 17, 2021 22:21
mastercactapus
mastercactapus requested changes May 18, 2021
View reviewed changes
Comment thread graphql2/graphqlapp/user.go Outdated
Comment thread app/initstores.go Outdated
Comment thread app/app.go Outdated
@dctalbot dctalbot requested a review from mastercactapus May 18, 2021 21:20
Lanithane
Lanithane suggested changes May 19, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Lanithane Lanithane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but functionally I'm seeing field errors for username show up under the display name field instead

@dctalbot
Copy link
Copy Markdown
Contributor Author

dctalbot commented May 19, 2021 •
edited
Loading

Code looks good, but functionally I'm seeing field errors for username show up under the display name field instead

Steps to reproduce? I'm not seeing that @Forfold

@Lanithane
Copy link
Copy Markdown
Contributor

Lanithane commented May 19, 2021

For sure:

  1. Set username to something "test " (note the space at the end)
  2. Fill in rest of required fields
  3. Attempt submit

Screen Shot 2021-05-19 at 1 25 03 PM

@dctalbot dctalbot requested a review from Lanithane May 19, 2021 21:52
mastercactapus
mastercactapus requested changes May 20, 2021
View reviewed changes
Comment thread app/initgraphql.go Outdated
Comment thread graphql2/graphqlapp/app.go Outdated
dctalbot and others added 2 commits May 20, 2021 11:24
@dctalbot @mastercactapus
use pointer type
121e024 
Co-authored-by: Nathaniel Caza <mastercactapus@gmail.com>
@dctalbot
use pointer type
6acb32c
Lanithane
Lanithane approved these changes May 20, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Lanithane Lanithane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@dctalbot dctalbot requested a review from mastercactapus May 20, 2021 15:35
@dctalbot dctalbot merged commit 2f06977 into master May 20, 2021
@dctalbot dctalbot deleted the create-user branch May 20, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mastercactapus mastercactapus mastercactapus approved these changes

+1 more reviewer

@Lanithane Lanithane Lanithane approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dctalbot @mastercactapus @Lanithane