lib: migrate to a maintained UUID library#1654
Merged
Merged
Conversation
Not required for the package change itself, but for next-up work of converting from string to uuid in structs.
dctalbot
suggested changes
Jun 23, 2021
Comment on lines
+32
to
+35
| if idStr == "" { | ||
| return false | ||
| } | ||
| return c.UserExistsUUID(uuid.FromStringOrNil(id)) | ||
| id, _ := uuid.Parse(idStr) |
Contributor
There was a problem hiding this comment.
This is minor, but feels off to have one error condition (empty string) return false and any others be ignored. Maybe check for all in one go?
id, err := uuid.Parse(idStr)
if err != nil {
return false
}
Member
Author
There was a problem hiding this comment.
oh, yeah I like that much better -- prevents the possibility of an invalid UUID returning true if there was a nil user
Contributor
|
|
Member
Author
@dctalbot no, I was trying to figure out why |
dctalbot
approved these changes
Jun 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make checkto catch common errors. Fixed any that came up.Description:
Switches to a maintained UUID library.