search: update user search behavior to filter by prefix#1872
Merged
Conversation
KatieMSB
previously approved these changes
Aug 26, 2021
m17ch
previously approved these changes
Aug 26, 2021
KatieMSB
approved these changes
Aug 27, 2021
m17ch
approved these changes
Aug 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates user search to follow a prefix-based approach.
Originally search was a simple substring match:
"abc" would match
Recently a change was merged that uses a word-based approach:
"abc" would match only
The new form makes sense for many services/policies/schedules as those are usually word-based. Names, however, can vary. This made it difficult as you'd need to type the entire first and/or last name to find a user, as partial matches would not work.
This PR implements a new strategy where each "word" of the search string must at least match a prefix of a "word" in the user's name.
"abc" would match
Additionally, you could further restrict your search by adding multiple terms:
"f ab"
Matching both:
Which issue(s) this PR fixes:
As part of this, a fix is included to ensure search selects always reflect backend search results
Fixes #919
Out of Scope:
This change does not affect any search functionality beyond users.