Skip to content

ui/services: Alert metrics dashboard#2085

Merged
dctalbot merged 63 commits into
masterfrom
alert-metrics
Jan 18, 2022
Merged

ui/services: Alert metrics dashboard#2085
dctalbot merged 63 commits into
masterfrom
alert-metrics

Conversation

@dctalbot

@dctalbot dctalbot commented Jan 6, 2022

Copy link
Copy Markdown
Contributor
  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This PR is the first iteration of the Alert Metrics dashboard feature. It provides:

  • a new Service Details quick link page that displays metrics for a given service
  • a graph of alert counts, grouped by date in the user's system timezone (shows 100 alerts max).
  • a table of alert details
  • a date range filter to view the past 1, 2, 3, or 4 weeks of alerts.
  • a CSV export button

Screenshots:
Screen Shot 2022-01-10 at 12 12 15 PM

@dctalbot dctalbot marked this pull request as draft January 6, 2022 19:50
@KatieMSB KatieMSB changed the title Alert metrics dashboard ui/services: Alert metrics dashboard Jan 10, 2022
@KatieMSB KatieMSB marked this pull request as ready for review January 10, 2022 18:15
Comment thread web/src/app/services/AlertMetrics/AlertMetrics.tsx Outdated
@Lanithane Lanithane self-requested a review January 13, 2022 20:15
@dctalbot dctalbot requested a review from arurao January 14, 2022 16:00
Comment thread web/src/app/services/ServiceDetails.js Outdated
Comment thread web/src/app/services/AlertMetrics/AlertMetricsCSV.tsx Outdated
Comment thread web/src/app/selection/QuerySelect.js Outdated
Comment thread web/src/app/services/AlertMetrics/AlertMetricsCSV.tsx
@dctalbot dctalbot requested a review from Lanithane January 18, 2022 17:22

@Lanithane Lanithane left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Loads well with a clean console 🎉 Functionally tested exporting a CSV of alerts as well.

@arurao arurao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Functionally validated. Nice work!

@dctalbot dctalbot merged commit a2b8255 into master Jan 18, 2022
@dctalbot dctalbot deleted the alert-metrics branch January 18, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants