ui/services: Alert metrics dashboard#2085
Merged
Merged
Conversation
Lanithane
suggested changes
Jan 17, 2022
Lanithane
approved these changes
Jan 18, 2022
Lanithane
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Loads well with a clean console 🎉 Functionally tested exporting a CSV of alerts as well.
arurao
approved these changes
Jan 18, 2022
arurao
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Functionally validated. Nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make checkto catch common errors. Fixed any that came up.Description:
This PR is the first iteration of the Alert Metrics dashboard feature. It provides:
Screenshots:
