Skip to content

tracing: Remove tracing code#2420

Merged
mastercactapus merged 4 commits into
masterfrom
remove-tracing-code
Jun 6, 2022
Merged

tracing: Remove tracing code#2420
mastercactapus merged 4 commits into
masterfrom
remove-tracing-code

Conversation

@mastercactapus
Copy link
Copy Markdown
Member

Description:
This PR removes unmaintained tracing code and dependencies. The following flags have been deprecated and no longer function:

  • jaeger-endpoint
  • jaeger-agent-endpoint
  • stackdriver-project-id
  • tracing-cluster-name
  • tracing-pod-namespace
  • tracing-pod-name
  • tracing-container-name
  • tracing-node-name
  • tracing-probability

Using the flags will not prevent GoAlert from starting, but a warning will be printed.

Which issue(s) this PR fixes:
Closes #2158

Copy link
Copy Markdown
Contributor

@m17ch m17ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Copy link
Copy Markdown
Contributor

@Lanithane Lanithane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mastercactapus mastercactapus merged commit 094d4e2 into master Jun 6, 2022
@mastercactapus mastercactapus deleted the remove-tracing-code branch June 6, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

debt: remove unmaintained tracing code

3 participants