ui/services: convert IntegrationKeyCreateDialog & IntegrationKeyList to ts#2568
Merged
Conversation
added 2 commits
July 5, 2022 13:10
KatieMSB
requested changes
Sep 8, 2022
Co-authored-by: Katie Sydlik-Badgerow <38022260+KatieMSB@users.noreply.github.com>
…rget/goalert into ts-IntegrationKeyCreateDialog
…tegrationKeyCreateDialog
KatieMSB
previously approved these changes
Sep 23, 2022
added 2 commits
September 26, 2022 13:33
…tegrationKeyCreateDialog
KatieMSB
previously approved these changes
Oct 3, 2022
Lanithane
reviewed
Oct 7, 2022
Lanithane
reviewed
Oct 7, 2022
Lanithane
suggested changes
Oct 7, 2022
Lanithane
left a comment
Contributor
There was a problem hiding this comment.
just a couple small things ^ otherwise looks good
Co-authored-by: Nathaniel Cook <NathanielJCook@outlook.com>
Lanithane
previously approved these changes
Oct 13, 2022
KatieMSB
approved these changes
Oct 13, 2022
Lanithane
approved these changes
Oct 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make checkto catch common errors. Fixed any that came up.Description:
Part of an ongoing effort to convert existing javascript files to typescript.
Note: IntegrationKeyCreateDialog and IntegrationKeyList were both converted in this PR to avoid receiving this error:
Cannot destructure property 'service' of 'cache5.readQuery(...)' as it is null.This error occurs when IntegrationKeyCreateDialog.js created a new integration key without a cache available in IntegrationKeyList.tsx, since IntegrationKeyList.tsx uses urql instead of apollo now.
Which issue(s) this PR fixes:
#2318
Out of Scope: