override: use static query for override search#3317
Merged
Conversation
andrewbenington
approved these changes
Oct 3, 2023
KatieMSB
approved these changes
Oct 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR replaces the dynamic/rendered search query with a fixed one using sqlc.
Which issue(s) this PR fixes:
Part of #3235
Out of Scope:
Describe any introduced API changes:
The behavior should be identical to the prior implementation; however, the query is no longer dynamic, and at most 1 query will be prepared/cached/planned in the DB.
Additional Info:
Since the limit is now fixed to the max (150), it's no longer necessary to validate the limit argument as it is only used to return less than the max and is no longer part of rendering the actually executed query.