ui/temp-sched: Add fixed shifts for temporary schedules#3606
Merged
Conversation
Lanithane
suggested changes
Jan 18, 2024
Contributor
There was a problem hiding this comment.
Looks like the type/padding is getting messed up for the day interval here (this is on open without making any changes)
Also, can we make it so the shift length can be temporarily null? With it set to 1 day, I tried to change it to 6 hours by typing Backspace then 6, but it wouldn't let me so I had to use the arrow keys. But with the arrow keys, there was a bit of lag for each digit as it went up to render everything on the right
Lanithane
approved these changes
Jan 18, 2024
Contributor
Lanithane
left a comment
There was a problem hiding this comment.
LGTM! Working well & as intended
ethan-haynes
approved these changes
Jan 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make checkto catch common errors. Fixed any that came up.Description:
Adds new fields in the temporary schedule dialogs to have fixed shifts for the entire schedule. Shift duration defaults to 1 Day for all shifts but shifts can still be added with custom durations in the Add Shift form. Coverage gaps are also now rendered by the set shift duration, and more clearly show the time frame without coverage.
Which issue(s) this PR fixes:
Part of #3492
Screenshots:
