Skip to content

Less statics #14668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sftse wants to merge 20 commits into
base: dev
Choose a base branch
from
Open

Less statics #14668

sftse wants to merge 20 commits into from
+669 −720

Conversation

@sftse
Copy link
Contributor

@sftse sftse commented Dec 17, 2025 •
edited
Loading

Work on refactoring the globals in tauri-cli. I think this is beneficial as-is, but it is not quite finished.

This still is missing a full transition towards lazy initialized tauri_dir and frontend_dir while guaranteeing not to break anything, as discussed in this comment.
Completed.

Read commit-by-commit.

@sftse sftse requested a review from a team as a code owner December 17, 2025 15:31
@github-project-automation github-project-automation bot moved this to 📬Proposal in Roadmap Dec 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2025 •
edited
Loading

Package Changes Through ee5d876

There are 4 changes which include tauri-utils with patch, tauri-build with patch, tauri-cli with patch, tauri with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-utils 2.8.1 2.8.2
tauri-bundler 2.7.5 2.7.6
tauri-runtime 2.9.2 2.9.3
tauri-runtime-wry 2.9.3 2.9.4
tauri-codegen 2.5.2 2.5.3
tauri-macros 2.5.2 2.5.3
tauri-plugin 2.5.2 2.5.3
tauri-build 2.5.3 2.5.4
tauri 2.9.5 2.9.6
@tauri-apps/cli 2.9.6 2.9.7
tauri-cli 2.9.6 2.9.7

Add another change file through the GitHub UI by following this link.

Read about change files or the docs at github.com/jbolda/covector

@sftse
Copy link
Contributor Author

sftse commented Dec 18, 2025

Any chance to run CI automatically on my PRs? Would make iteration much faster, I often miss things built only on other platforms.

@FabianLars
Copy link
Member

FabianLars commented Dec 19, 2025

Any chance to run CI automatically on my PRs? Would make iteration much faster, I often miss things built only on other platforms.

That decision will probably take longer to discuss than your pr will be open x)

@sftse sftse force-pushed the less-statics branch 2 times, most recently from ee5a7b4 to a1b4415 Compare December 19, 2025 22:19
@sftse
Copy link
Contributor Author

sftse commented Dec 19, 2025

This is RFR

sftse added 18 commits December 21, 2025 15:07
@sftse
refactor(tauri-cli): introduce replacement functions
de08b69
@sftse
refactor(tauri-cli): apply replacement to remove.rs
011ed93
@sftse
refactor(tauri-cli): apply replacement to icon.rs
5cb6647
@sftse
refactor(tauri-cli): apply replacement to bundle.rs
7a6b56d
@sftse
refactor(tauri-cli): apply replacement to build.rs
388dc70
@sftse
refactor(tauri-cli): apply replacement to add.rs
2dda068
@sftse
refactor(tauri-cli): apply replacement to dev.rs
fe57ea1
@sftse
refactor(tauri-cli): less controlflow
022f19f
@sftse
refactor(tauri-cli): split config loading from locking static
0c01cc4
@sftse
refactor(tauri-cli): remove duplicate checks covered by if let Some(t…
add6852 
…auri_dir) = tauri_dir

tauri_dir.is_some() must be true, otherwise the entire block is not run, so the frontend_dir check
is irrelevant
@sftse
fmt
179c796
@sftse
refactor(tauri-cli): apply replacement to inspect.rs
6beb88f
@sftse
refactor(tauri-cli): dont use statics for config
0f8c74b
@sftse
refactor(tauri-cli): finish threading directory paths through functions
9998b1f
@sftse
fix: clippy
9cd3d44
@sftse
fixup CI
41d4dc6
@sftse
refactor(tauri-cli): dont need mutex
ade439c
@sftse
refactor(tauri-cli): rescope mutex use to minimal necessary
8e2dfc7
@sftse
Copy link
Contributor Author

sftse commented Dec 21, 2025

@FabianLars
I put effort into readable commits that compile individually. High-latency round trips reduce the quality of my contributions, here the last commits merge multiple unrelated things because it takes way too long to figure out what is related.

RFR

@sftse
Copy link
Contributor Author

sftse commented Dec 21, 2025

Fixed next errors

@FabianLars
Copy link
Member

FabianLars commented Dec 21, 2025

I put effort into readable commits that compile individually. High-latency round trips reduce the quality of my contributions, here the last commits merge multiple unrelated things because it takes way too long to figure out what is related.

Yeah i totally get that. GitHub only offers us 2 options: Auto run workflows for everyone or only for those with write permissions. There's no way to give individuals workflow permissions without also giving write access to the repo. All in all very annoying.

You could however enable workflow runs in your own fork (free of charge since it's open source) and open a second PR from your branch against your own fork's dev branch.

@sftse
Copy link
Contributor Author

sftse commented Dec 22, 2025

You could however enable workflow runs in your own fork (free of charge since it's open source) and open a second PR from your branch against your own fork's dev branch.

Didn't think of that, I'm not familiar with the workflows.
I might take that for a spin, thanks.

@FabianLars
Copy link
Member

FabianLars commented Dec 22, 2025

whoops sorry, didn't mean to click on button...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

Roadmap
Status: 📬Proposal

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sftse @FabianLars