Context & design feedback on my four open PRs (#984–#987 + harlequin-postgres#56) #989
scantinibudden
started this conversation in
Ideas (Feature Requests)
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Hi Ted 👋
Last week I opened four PRs (#984, #985, #986, #987, plus tconbeer/harlequin-postgres#56) without proposing them here first — I only just read CONTRIBUTING properly and realized Discussions is where feature ideas should start. Sorry for the cold PRs! Rather than opening four retroactive threads, here's the missing context in one place.
Background: I use Harlequin daily as my main SQL IDE against Postgres. These features all came from my personal fork, where I built them to smooth out my own browsing/editing workflow. I split them into small, independent PRs in the hope some are useful upstream.
The features:
select * from <rel> limit 100instead of just inserting the name into the editor. As flagged in the PR: this changes a default behavior, and I'm happy to gate it behind a config option (or drop it if you like the current behavior).↗glyph; clicking follows the reference. Requires adapter support — harlequin-postgres#56 addsforeign_key_columns()to the cursor.UPDATEkeyed on the primary key. Requireseditable_columns()from the same adapter PR. This is the most opinionated of the four (a results viewer that can write back), so I fully understand if you'd want it opt-in — or consider it out of scope for Harlequin.How they relate: #986 and #987 share the adapter plumbing in harlequin-postgres#56; #984 and #985 are independent of everything else. #987 stays draft until #986 lands (or doesn't).
No urgency on any of this — I'm running my fork happily in the meantime. Very open to reworking UX, gating behavior, or closing any PR that doesn't fit your vision for Harlequin. Thanks for building it!
All reactions