Fix yet another bug with go-gettable modules #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was another bug needing to be fixed in techknowlogick#187 - /source/go.mod does not exist in go-gettable modules therefore the NAME determination will fail. Fix techknowlogick#187 Signed-off-by: Andrew Thornton <art27@cantab.net>
Collaborator
Author
|
I think this must have been missed because of the problem in the CI where it isn't testing with the rebuilt dockers |
Collaborator
Author
|
We're still not using the recreated dockers in the bats tests... I'm trying to hack this in but it's totally opaque as to how to force bats to use rebuilt dockers. |
1326b8e to
49d1ed7
Compare
Collaborator
Author
|
OK I give up on trying to get the CI to work properly for the moment. I've pushed this PR back to the simple fix. @techknowlogick you might need to just forcibly merge and I'll try to work out how we can have a CI that actually tests what the PRs are doing. |
6543
added a commit
to woodpecker-ci/woodpecker
that referenced
this pull request
Jan 13, 2023
made possible again by: - techknowlogick/xgo#189 - techknowlogick/xgo#193
|
@zeripath my binaries build nicely again using this patch, thank you 🎩 |
Collaborator
Author
|
well it's probably a combination of this one & #194. |
Collaborator
Author
|
sorry that things were broken for so long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was another bug needing to be fixed in #187 - /source/go.mod does not exist in go-gettable modules therefore the NAME determination will fail.
Fix #187
Signed-off-by: Andrew Thornton art27@cantab.net