-
Notifications
You must be signed in to change notification settings - Fork 878
Load system and user config files after init. Should help with #107. #108
Conversation
…mancy#107. ALMOST ENTIRELY UNTESTED.
|
Oh, cool; I didn't know about that hook. That's been tripping up a lot of people; thanks! |
Load system and user config files after init. Should help with #107.
|
Make sure you test it. I haven't actually confirmed that the function works at init time. The trick is that |
|
It helps, but only after wrapping config autoloads to esk-eval-after-init this way: I'm not sure how to provide appropriate fix for this issue, because autoloads are auto-generated. |
|
Is is possible that the autoloads file was left over from an earlier version that didn't have my fix? |
|
Yes. you have to regenerate autoloads after applying patch |
|
Yes, I've patched already installed version. 25.11.2011, 08:48, "Ryan Thompson" reply@reply.github.com:
Best regards, |
|
Yes, thanks. It worked for me. 25.11.2011, 14:08, "Maciej Mazur" reply@reply.github.com:
Best regards, |
|
Thanks for merging this in, it should make things much easier. @technomancy, will this be released to marmalade soon? |
|
Has anyone tested this? Does it work well? I don't use ESK myself; I just have an interest in it since it started depending on my ido-ubiquitous package. |
|
To be honest it'll probably be a couple weeks before I get a chance to cut a release. I'll be sure to test it thoroughly before it's pushed out. |
|
I've been using it and it has been working like a charm. :) I am on the latest version of the code and I haven't ran into any issues. |
|
It works very well (no problem since 25.11.2011). 19.01.2012, 07:31, "Ryan Thompson" reply@reply.github.com:
Best regards, |
|
Glad to know it works. |
If my code is correct, this pull request should result in the user and system config files being loaded after init, and hence after all other packages have been loaded.
This should fix #107, assuming that the code works.