Skip to content

Conversation

@mac641
Copy link
Contributor

@mac641 mac641 commented Sep 25, 2020

  • Apply Singleton design pattern to LocalDatabaseManager to avoid crashes mentioned in Known issues
  • Move validation functions to ConfigUtils
  • Fix toast bug when there's no connection to remote server available
  • Update README.md
  • Push to v1.0-rc03
  • Refactor / Reformat

@mac641 mac641 added bug Something isn't working implement Fresh code is added refactor Existing code is changed for the greater good xD labels Sep 25, 2020
@mac641 mac641 added this to the v1.0 milestone Sep 25, 2020
@mac641 mac641 self-assigned this Sep 25, 2020
Copy link
Contributor

@craftamap craftamap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Work!
I also tested the changes on device and they seem to be resolved now.
Lets get this merged!

@mac641 mac641 merged commit 0bceb03 into master Sep 26, 2020
@mac641 mac641 deleted the database_fix branch September 26, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working implement Fresh code is added refactor Existing code is changed for the greater good xD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants