Fix some tests to actually check properly #988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Teal Playground URL: https://988--teal-playground-preview.netlify.app |
Member
|
Thanks for catching those! That's what we get for writing tests in Lua instead of Teal 😬 (But still, I think keeping it in Lua is fine if only to avoid the chicken-and-egg situation — also the reason why the compiler build uses that two-step Makefile instead of relying on Cyan...) |
hishamhm
approved these changes
May 19, 2025
Member
hishamhm
left a comment
There was a problem hiding this comment.
For commits that affect only the spec/ subtree, I've been always prefixing them with tests: ; it makes it easier for me to scan them when looking for features when updating the changelog.
I see it's still marked as draft, so I assume you intend to make more changes -- but feel free to commit those whenever you think they're ready!
068c893 to
63c814c
Compare
63c814c to
97ca99e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a few ones that weren't actually checking properly.