Skip to content

Conversation

@afrittoli
Copy link
Member

Add a second script to resolve github user ids, that reduces a bit
the amount of work that needs to be done with the original script.

Add an updated user list for 2021.

Signed-off-by: Andrea Frittoli andrea.frittoli@gmail.com

Add a second script to resolve github user ids, that reduces a bit
the amount of work that needs to be done with the original script.

Add an updated user list for 2021.

Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 25, 2021
@afrittoli
Copy link
Member Author

/cc @iancoffey @bobcatfish 🙏

Copy link
Contributor

@bobcatfish bobcatfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly just wondering if we could delete the previous script in favor of the new one

@@ -1,4 +1,4 @@
#!/user/bin/env python3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

@@ -0,0 +1,51 @@
#!/usr/bin/env python3

"""get_emails_2.py Extracts github IDs from a CSV and matches them
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason not to replace the other script?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can run this first on the output of grafana, and then run the other script on the missing list produced by this script.
Reason being that the first script is more likely to give clean results, but also to have many miss.
I should have documented this better? Or maybe aggregated the two steps? I was a bit lazy :P

Copy link
Member

@iancoffey iancoffey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm, thanks for doing this

@afrittoli afrittoli closed this Feb 26, 2021
@afrittoli afrittoli reopened this Feb 26, 2021
@afrittoli afrittoli closed this Feb 26, 2021
@afrittoli afrittoli reopened this Feb 26, 2021
@afrittoli afrittoli closed this Feb 26, 2021
@afrittoli afrittoli reopened this Feb 26, 2021
@afrittoli afrittoli closed this Feb 26, 2021
@afrittoli afrittoli reopened this Feb 26, 2021
@afrittoli afrittoli closed this Feb 26, 2021
@afrittoli afrittoli reopened this Feb 26, 2021
@afrittoli afrittoli closed this Mar 1, 2021
@afrittoli afrittoli reopened this Mar 1, 2021
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2021
@vdemeester
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2021
@tekton-robot tekton-robot merged commit f07cdab into tektoncd:main Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants