-
Notifications
You must be signed in to change notification settings - Fork 87
Add delete count and duration metrics for TaskRun and PipelineRun #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @xinnjie. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @adambkaplan |
|
/ok-to-test |
6207337 to
6e30422
Compare
|
/assign @enarha |
6e30422 to
e10a6b6
Compare
|
@xinnjie Thank you for your contribution. I'm taking a look and hopefully I'll be able to finish before EOD. |
enarha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
/approve
78ab9e8 to
2667702
Compare
|
/cc @vdemeester @khrm @sayan-biswas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, nice job 👏🏼
/approve
Metrics from the test
# HELP watcher_client_latency How long Kubernetes API requests take
# TYPE watcher_client_latency histogram
watcher_client_latency_bucket{name="",le="1e-05"} 0
watcher_client_latency_bucket{name="",le="0.0001"} 0
watcher_client_latency_bucket{name="",le="0.001"} 0
watcher_client_latency_bucket{name="",le="0.01"} 490
watcher_client_latency_bucket{name="",le="0.1"} 539
watcher_client_latency_bucket{name="",le="1"} 542
watcher_client_latency_bucket{name="",le="10"} 542
watcher_client_latency_bucket{name="",le="100"} 542
watcher_client_latency_bucket{name="",le="+Inf"} 542
watcher_client_latency_sum{name=""} 2.972853399999999
watcher_client_latency_count{name=""} 542
# HELP watcher_client_results Total number of API requests (broken down by status code)
# TYPE watcher_client_results counter
watcher_client_results{name=""} 552
# HELP watcher_go_alloc The number of bytes of allocated heap objects.
# TYPE watcher_go_alloc gauge
watcher_go_alloc{name=""} 6.249648e+06
# HELP watcher_go_bucket_hash_sys The number of bytes of memory in profiling bucket hash tables.
# TYPE watcher_go_bucket_hash_sys gauge
watcher_go_bucket_hash_sys{name=""} 1.489362e+06
# HELP watcher_go_frees The cumulative count of heap objects freed.
# TYPE watcher_go_frees gauge
watcher_go_frees{name=""} 994179
# HELP watcher_go_gc_cpu_fraction The fraction of this program's available CPU time used by the GC since the program started.
# TYPE watcher_go_gc_cpu_fraction gauge
watcher_go_gc_cpu_fraction{name=""} 1.5235795174626053e-05
# HELP watcher_go_gc_sys The number of bytes of memory in garbage collection metadata.
# TYPE watcher_go_gc_sys gauge
watcher_go_gc_sys{name=""} 9.099176e+06
# HELP watcher_go_heap_alloc The number of bytes of allocated heap objects.
# TYPE watcher_go_heap_alloc gauge
watcher_go_heap_alloc{name=""} 6.249648e+06
# HELP watcher_go_heap_idle The number of bytes in idle (unused) spans.
# TYPE watcher_go_heap_idle gauge
watcher_go_heap_idle{name=""} 9.674752e+06
# HELP watcher_go_heap_in_use The number of bytes in in-use spans.
# TYPE watcher_go_heap_in_use gauge
watcher_go_heap_in_use{name=""} 1.0313728e+07
# HELP watcher_go_heap_objects The number of allocated heap objects.
# TYPE watcher_go_heap_objects gauge
watcher_go_heap_objects{name=""} 33272
# HELP watcher_go_heap_released The number of bytes of physical memory returned to the OS.
# TYPE watcher_go_heap_released gauge
watcher_go_heap_released{name=""} 4.325376e+06
# HELP watcher_go_heap_sys The number of bytes of heap memory obtained from the OS.
# TYPE watcher_go_heap_sys gauge
watcher_go_heap_sys{name=""} 1.998848e+07
# HELP watcher_go_last_gc The time the last garbage collection finished, as nanoseconds since 1970 (the UNIX epoch).
# TYPE watcher_go_last_gc gauge
watcher_go_last_gc{name=""} 1.689334320090288e+18
# HELP watcher_go_lookups The number of pointer lookups performed by the runtime.
# TYPE watcher_go_lookups gauge
watcher_go_lookups{name=""} 0
# HELP watcher_go_mallocs The cumulative count of heap objects allocated.
# TYPE watcher_go_mallocs gauge
watcher_go_mallocs{name=""} 1.027451e+06
# HELP watcher_go_mcache_in_use The number of bytes of allocated mcache structures.
# TYPE watcher_go_mcache_in_use gauge
watcher_go_mcache_in_use{name=""} 4800
# HELP watcher_go_mcache_sys The number of bytes of memory obtained from the OS for mcache structures.
# TYPE watcher_go_mcache_sys gauge
watcher_go_mcache_sys{name=""} 15600
# HELP watcher_go_mspan_in_use The number of bytes of allocated mspan structures.
# TYPE watcher_go_mspan_in_use gauge
watcher_go_mspan_in_use{name=""} 182240
# HELP watcher_go_mspan_sys The number of bytes of memory obtained from the OS for mspan structures.
# TYPE watcher_go_mspan_sys gauge
watcher_go_mspan_sys{name=""} 228480
# HELP watcher_go_next_gc The target heap size of the next GC cycle.
# TYPE watcher_go_next_gc gauge
watcher_go_next_gc{name=""} 1.2828088e+07
# HELP watcher_go_num_forced_gc The number of GC cycles that were forced by the application calling the GC function.
# TYPE watcher_go_num_forced_gc gauge
watcher_go_num_forced_gc{name=""} 0
# HELP watcher_go_num_gc The number of completed GC cycles.
# TYPE watcher_go_num_gc gauge
watcher_go_num_gc{name=""} 21
# HELP watcher_go_other_sys The number of bytes of memory in miscellaneous off-heap runtime allocations.
# TYPE watcher_go_other_sys gauge
watcher_go_other_sys{name=""} 829982
# HELP watcher_go_stack_in_use The number of bytes in stack spans.
# TYPE watcher_go_stack_in_use gauge
watcher_go_stack_in_use{name=""} 983040
# HELP watcher_go_stack_sys The number of bytes of stack memory obtained from the OS.
# TYPE watcher_go_stack_sys gauge
watcher_go_stack_sys{name=""} 983040
# HELP watcher_go_sys The total bytes of memory obtained from the OS.
# TYPE watcher_go_sys gauge
watcher_go_sys{name=""} 3.263412e+07
# HELP watcher_go_total_alloc The cumulative bytes allocated for heap objects.
# TYPE watcher_go_total_alloc gauge
watcher_go_total_alloc{name=""} 9.7870248e+07
# HELP watcher_go_total_gc_pause_ns The cumulative nanoseconds in GC stop-the-world pauses since the program started.
# TYPE watcher_go_total_gc_pause_ns gauge
watcher_go_total_gc_pause_ns{name=""} 2.2065e+06
# HELP watcher_reconcile_count Number of reconcile operations
# TYPE watcher_reconcile_count counter
watcher_reconcile_count{namespace_name="default",reconciler="PipelineRuns",success="false"} 11
watcher_reconcile_count{namespace_name="default",reconciler="PipelineRuns",success="true"} 27
watcher_reconcile_count{namespace_name="default",reconciler="TaskRuns",success="false"} 8
watcher_reconcile_count{namespace_name="default",reconciler="TaskRuns",success="true"} 53
# HELP watcher_reconcile_latency Latency of reconcile operations
# TYPE watcher_reconcile_latency histogram
watcher_reconcile_latency_bucket{namespace_name="default",reconciler="PipelineRuns",success="false",le="10"} 0
watcher_reconcile_latency_bucket{namespace_name="default",reconciler="PipelineRuns",success="false",le="100"} 1
watcher_reconcile_latency_bucket{namespace_name="default",reconciler="PipelineRuns",success="false",le="1000"} 1
watcher_reconcile_latency_bucket{namespace_name="default",reconciler="PipelineRuns",success="false",le="10000"} 11
watcher_reconcile_latency_bucket{namespace_name="default",reconciler="PipelineRuns",success="false",le="30000"} 11
watcher_reconcile_latency_bucket{namespace_name="default",reconciler="PipelineRuns",success="false",le="60000"} 11
watcher_reconcile_latency_bucket{namespace_name="default",reconciler="PipelineRuns",success="false",le="+Inf"} 11
watcher_reconcile_latency_sum{namespace_name="default",reconciler="PipelineRuns",success="false"} 29723
watcher_reconcile_latency_count{namespace_name="default",reconciler="PipelineRuns",success="false"} 11
watcher_reconcile_latency_bucket{namespace_name="default",reconciler="PipelineRuns",success="true",le="10"} 0
watcher_reconcile_latency_bucket{namespace_name="default",reconciler="PipelineRuns",success="true",le="100"} 1
watcher_reconcile_latency_bucket{namespace_name="default",reconciler="PipelineRuns",success="true",le="1000"} 3
watcher_reconcile_latency_bucket{namespace_name="default",reconciler="PipelineRuns",success="true",le="10000"} 27
watcher_reconcile_latency_bucket{namespace_name="default",reconciler="PipelineRuns",success="true",le="30000"} 27
watcher_reconcile_latency_bucket{namespace_name="default",reconciler="PipelineRuns",success="true",le="60000"} 27
watcher_reconcile_latency_bucket{namespace_name="default",reconciler="PipelineRuns",success="true",le="+Inf"} 27
watcher_reconcile_latency_sum{namespace_name="default",reconciler="PipelineRuns",success="true"} 62047.999999999985
watcher_reconcile_latency_count{namespace_name="default",reconciler="PipelineRuns",success="true"} 27
watcher_reconcile_latency_bucket{namespace_name="default",reconciler="TaskRuns",success="false",le="10"} 6
watcher_reconcile_latency_bucket{namespace_name="default",reconciler="TaskRuns",success="false",le="100"} 7
watcher_reconcile_latency_bucket{namespace_name="default",reconciler="TaskRuns",success="false",le="1000"} 7
watcher_reconcile_latency_bucket{namespace_name="default",reconciler="TaskRuns",success="false",le="10000"} 8
watcher_reconcile_latency_bucket{namespace_name="default",reconciler="TaskRuns",success="false",le="30000"} 8
watcher_reconcile_latency_bucket{namespace_name="default",reconciler="TaskRuns",success="false",le="60000"} 8
watcher_reconcile_latency_bucket{namespace_name="default",reconciler="TaskRuns",success="false",le="+Inf"} 8
watcher_reconcile_latency_sum{namespace_name="default",reconciler="TaskRuns",success="false"} 1644
watcher_reconcile_latency_count{namespace_name="default",reconciler="TaskRuns",success="false"} 8
watcher_reconcile_latency_bucket{namespace_name="default",reconciler="TaskRuns",success="true",le="10"} 0
watcher_reconcile_latency_bucket{namespace_name="default",reconciler="TaskRuns",success="true",le="100"} 8
watcher_reconcile_latency_bucket{namespace_name="default",reconciler="TaskRuns",success="true",le="1000"} 12
watcher_reconcile_latency_bucket{namespace_name="default",reconciler="TaskRuns",success="true",le="10000"} 53
watcher_reconcile_latency_bucket{namespace_name="default",reconciler="TaskRuns",success="true",le="30000"} 53
watcher_reconcile_latency_bucket{namespace_name="default",reconciler="TaskRuns",success="true",le="60000"} 53
watcher_reconcile_latency_bucket{namespace_name="default",reconciler="TaskRuns",success="true",le="+Inf"} 53
watcher_reconcile_latency_sum{namespace_name="default",reconciler="TaskRuns",success="true"} 103740.00000000001
watcher_reconcile_latency_count{namespace_name="default",reconciler="TaskRuns",success="true"} 53
# HELP watcher_results_pipelinerun_delete_count total number of deleted pipelineruns
# TYPE watcher_results_pipelinerun_delete_count counter
watcher_results_pipelinerun_delete_count{namespace="default",status="success"} 7
# HELP watcher_results_pipelinerun_delete_duration_seconds total number of deleted pipelineruns
# TYPE watcher_results_pipelinerun_delete_duration_seconds histogram
watcher_results_pipelinerun_delete_duration_seconds_bucket{namespace="default",pipeline="anonymous",status="success",le="10"} 7
watcher_results_pipelinerun_delete_duration_seconds_bucket{namespace="default",pipeline="anonymous",status="success",le="30"} 7
watcher_results_pipelinerun_delete_duration_seconds_bucket{namespace="default",pipeline="anonymous",status="success",le="60"} 7
watcher_results_pipelinerun_delete_duration_seconds_bucket{namespace="default",pipeline="anonymous",status="success",le="300"} 7
watcher_results_pipelinerun_delete_duration_seconds_bucket{namespace="default",pipeline="anonymous",status="success",le="900"} 7
watcher_results_pipelinerun_delete_duration_seconds_bucket{namespace="default",pipeline="anonymous",status="success",le="1800"} 7
watcher_results_pipelinerun_delete_duration_seconds_bucket{namespace="default",pipeline="anonymous",status="success",le="3600"} 7
watcher_results_pipelinerun_delete_duration_seconds_bucket{namespace="default",pipeline="anonymous",status="success",le="5400"} 7
watcher_results_pipelinerun_delete_duration_seconds_bucket{namespace="default",pipeline="anonymous",status="success",le="10800"} 7
watcher_results_pipelinerun_delete_duration_seconds_bucket{namespace="default",pipeline="anonymous",status="success",le="21600"} 7
watcher_results_pipelinerun_delete_duration_seconds_bucket{namespace="default",pipeline="anonymous",status="success",le="43200"} 7
watcher_results_pipelinerun_delete_duration_seconds_bucket{namespace="default",pipeline="anonymous",status="success",le="86400"} 7
watcher_results_pipelinerun_delete_duration_seconds_bucket{namespace="default",pipeline="anonymous",status="success",le="+Inf"} 7
watcher_results_pipelinerun_delete_duration_seconds_sum{namespace="default",pipeline="anonymous",status="success"} 49
watcher_results_pipelinerun_delete_duration_seconds_count{namespace="default",pipeline="anonymous",status="success"} 7
# HELP watcher_results_taskrun_delete_count total number of deleted taskruns
# TYPE watcher_results_taskrun_delete_count counter
watcher_results_taskrun_delete_count{namespace="default",status="success"} 9
# HELP watcher_results_taskrun_delete_duration_seconds the pipelinerun deletion time in seconds
# TYPE watcher_results_taskrun_delete_duration_seconds histogram
watcher_results_taskrun_delete_duration_seconds_bucket{namespace="default",pipeline="anonymous",status="success",task="anonymous",le="10"} 4
watcher_results_taskrun_delete_duration_seconds_bucket{namespace="default",pipeline="anonymous",status="success",task="anonymous",le="30"} 9
watcher_results_taskrun_delete_duration_seconds_bucket{namespace="default",pipeline="anonymous",status="success",task="anonymous",le="60"} 9
watcher_results_taskrun_delete_duration_seconds_bucket{namespace="default",pipeline="anonymous",status="success",task="anonymous",le="300"} 9
watcher_results_taskrun_delete_duration_seconds_bucket{namespace="default",pipeline="anonymous",status="success",task="anonymous",le="900"} 9
watcher_results_taskrun_delete_duration_seconds_bucket{namespace="default",pipeline="anonymous",status="success",task="anonymous",le="1800"} 9
watcher_results_taskrun_delete_duration_seconds_bucket{namespace="default",pipeline="anonymous",status="success",task="anonymous",le="3600"} 9
watcher_results_taskrun_delete_duration_seconds_bucket{namespace="default",pipeline="anonymous",status="success",task="anonymous",le="5400"} 9
watcher_results_taskrun_delete_duration_seconds_bucket{namespace="default",pipeline="anonymous",status="success",task="anonymous",le="10800"} 9
watcher_results_taskrun_delete_duration_seconds_bucket{namespace="default",pipeline="anonymous",status="success",task="anonymous",le="21600"} 9
watcher_results_taskrun_delete_duration_seconds_bucket{namespace="default",pipeline="anonymous",status="success",task="anonymous",le="43200"} 9
watcher_results_taskrun_delete_duration_seconds_bucket{namespace="default",pipeline="anonymous",status="success",task="anonymous",le="86400"} 9
watcher_results_taskrun_delete_duration_seconds_bucket{namespace="default",pipeline="anonymous",status="success",task="anonymous",le="+Inf"} 9
watcher_results_taskrun_delete_duration_seconds_sum{namespace="default",pipeline="anonymous",status="success",task="anonymous"} 93
watcher_results_taskrun_delete_duration_seconds_count{namespace="default",pipeline="anonymous",status="success",task="anonymous"} 9
# HELP watcher_work_queue_depth Depth of the work queue
# TYPE watcher_work_queue_depth gauge
watcher_work_queue_depth{reconciler="PipelineRuns"} 0
watcher_work_queue_depth{reconciler="TaskRuns"} 0
# HELP watcher_workqueue_adds_total Total number of adds handled by workqueue
# TYPE watcher_workqueue_adds_total counter
watcher_workqueue_adds_total{name="PipelineRuns-consumer"} 38
watcher_workqueue_adds_total{name="PipelineRuns-fast"} 54
watcher_workqueue_adds_total{name="TaskRuns-consumer"} 61
watcher_workqueue_adds_total{name="TaskRuns-fast"} 164
# HELP watcher_workqueue_depth Current depth of workqueue
# TYPE watcher_workqueue_depth gauge
watcher_workqueue_depth{name="PipelineRuns-consumer"} 0
watcher_workqueue_depth{name="PipelineRuns-fast"} 0
watcher_workqueue_depth{name="TaskRuns-consumer"} 0
watcher_workqueue_depth{name="TaskRuns-fast"} 0
# HELP watcher_workqueue_longest_running_processor_seconds How long in seconds the longest outstanding workqueue item has been in flight.
# TYPE watcher_workqueue_longest_running_processor_seconds histogram
watcher_workqueue_longest_running_processor_seconds_bucket{name="PipelineRuns-consumer",le="1e-08"} 2285
watcher_workqueue_longest_running_processor_seconds_bucket{name="PipelineRuns-consumer",le="1e-07"} 2285
watcher_workqueue_longest_running_processor_seconds_bucket{name="PipelineRuns-consumer",le="1e-06"} 2285
watcher_workqueue_longest_running_processor_seconds_bucket{name="PipelineRuns-consumer",le="9.999999999999999e-06"} 2285
watcher_workqueue_longest_running_processor_seconds_bucket{name="PipelineRuns-consumer",le="9.999999999999999e-05"} 2285
watcher_workqueue_longest_running_processor_seconds_bucket{name="PipelineRuns-consumer",le="0.001"} 2285
watcher_workqueue_longest_running_processor_seconds_bucket{name="PipelineRuns-consumer",le="0.01"} 2285
watcher_workqueue_longest_running_processor_seconds_bucket{name="PipelineRuns-consumer",le="0.1"} 2286
watcher_workqueue_longest_running_processor_seconds_bucket{name="PipelineRuns-consumer",le="1"} 2305
watcher_workqueue_longest_running_processor_seconds_bucket{name="PipelineRuns-consumer",le="10"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="PipelineRuns-consumer",le="+Inf"} 2387
watcher_workqueue_longest_running_processor_seconds_sum{name="PipelineRuns-consumer"} 178.71923299999992
watcher_workqueue_longest_running_processor_seconds_count{name="PipelineRuns-consumer"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="PipelineRuns-fast",le="1e-08"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="PipelineRuns-fast",le="1e-07"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="PipelineRuns-fast",le="1e-06"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="PipelineRuns-fast",le="9.999999999999999e-06"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="PipelineRuns-fast",le="9.999999999999999e-05"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="PipelineRuns-fast",le="0.001"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="PipelineRuns-fast",le="0.01"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="PipelineRuns-fast",le="0.1"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="PipelineRuns-fast",le="1"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="PipelineRuns-fast",le="10"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="PipelineRuns-fast",le="+Inf"} 2387
watcher_workqueue_longest_running_processor_seconds_sum{name="PipelineRuns-fast"} 0
watcher_workqueue_longest_running_processor_seconds_count{name="PipelineRuns-fast"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="PipelineRuns-slow",le="1e-08"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="PipelineRuns-slow",le="1e-07"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="PipelineRuns-slow",le="1e-06"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="PipelineRuns-slow",le="9.999999999999999e-06"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="PipelineRuns-slow",le="9.999999999999999e-05"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="PipelineRuns-slow",le="0.001"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="PipelineRuns-slow",le="0.01"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="PipelineRuns-slow",le="0.1"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="PipelineRuns-slow",le="1"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="PipelineRuns-slow",le="10"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="PipelineRuns-slow",le="+Inf"} 2387
watcher_workqueue_longest_running_processor_seconds_sum{name="PipelineRuns-slow"} 0
watcher_workqueue_longest_running_processor_seconds_count{name="PipelineRuns-slow"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="TaskRuns-consumer",le="1e-08"} 2281
watcher_workqueue_longest_running_processor_seconds_bucket{name="TaskRuns-consumer",le="1e-07"} 2281
watcher_workqueue_longest_running_processor_seconds_bucket{name="TaskRuns-consumer",le="1e-06"} 2281
watcher_workqueue_longest_running_processor_seconds_bucket{name="TaskRuns-consumer",le="9.999999999999999e-06"} 2281
watcher_workqueue_longest_running_processor_seconds_bucket{name="TaskRuns-consumer",le="9.999999999999999e-05"} 2281
watcher_workqueue_longest_running_processor_seconds_bucket{name="TaskRuns-consumer",le="0.001"} 2281
watcher_workqueue_longest_running_processor_seconds_bucket{name="TaskRuns-consumer",le="0.01"} 2281
watcher_workqueue_longest_running_processor_seconds_bucket{name="TaskRuns-consumer",le="0.1"} 2282
watcher_workqueue_longest_running_processor_seconds_bucket{name="TaskRuns-consumer",le="1"} 2302
watcher_workqueue_longest_running_processor_seconds_bucket{name="TaskRuns-consumer",le="10"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="TaskRuns-consumer",le="+Inf"} 2387
watcher_workqueue_longest_running_processor_seconds_sum{name="TaskRuns-consumer"} 182.71585910000002
watcher_workqueue_longest_running_processor_seconds_count{name="TaskRuns-consumer"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="TaskRuns-fast",le="1e-08"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="TaskRuns-fast",le="1e-07"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="TaskRuns-fast",le="1e-06"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="TaskRuns-fast",le="9.999999999999999e-06"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="TaskRuns-fast",le="9.999999999999999e-05"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="TaskRuns-fast",le="0.001"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="TaskRuns-fast",le="0.01"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="TaskRuns-fast",le="0.1"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="TaskRuns-fast",le="1"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="TaskRuns-fast",le="10"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="TaskRuns-fast",le="+Inf"} 2387
watcher_workqueue_longest_running_processor_seconds_sum{name="TaskRuns-fast"} 0
watcher_workqueue_longest_running_processor_seconds_count{name="TaskRuns-fast"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="TaskRuns-slow",le="1e-08"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="TaskRuns-slow",le="1e-07"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="TaskRuns-slow",le="1e-06"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="TaskRuns-slow",le="9.999999999999999e-06"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="TaskRuns-slow",le="9.999999999999999e-05"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="TaskRuns-slow",le="0.001"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="TaskRuns-slow",le="0.01"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="TaskRuns-slow",le="0.1"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="TaskRuns-slow",le="1"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="TaskRuns-slow",le="10"} 2387
watcher_workqueue_longest_running_processor_seconds_bucket{name="TaskRuns-slow",le="+Inf"} 2387
watcher_workqueue_longest_running_processor_seconds_sum{name="TaskRuns-slow"} 0
watcher_workqueue_longest_running_processor_seconds_count{name="TaskRuns-slow"} 2387
# HELP watcher_workqueue_queue_latency_seconds How long in seconds an item stays in workqueue before being requested.
# TYPE watcher_workqueue_queue_latency_seconds histogram
watcher_workqueue_queue_latency_seconds_bucket{name="PipelineRuns-consumer",le="1e-08"} 0
watcher_workqueue_queue_latency_seconds_bucket{name="PipelineRuns-consumer",le="1e-07"} 0
watcher_workqueue_queue_latency_seconds_bucket{name="PipelineRuns-consumer",le="1e-06"} 0
watcher_workqueue_queue_latency_seconds_bucket{name="PipelineRuns-consumer",le="9.999999999999999e-06"} 8
watcher_workqueue_queue_latency_seconds_bucket{name="PipelineRuns-consumer",le="9.999999999999999e-05"} 10
watcher_workqueue_queue_latency_seconds_bucket{name="PipelineRuns-consumer",le="0.001"} 11
watcher_workqueue_queue_latency_seconds_bucket{name="PipelineRuns-consumer",le="0.01"} 12
watcher_workqueue_queue_latency_seconds_bucket{name="PipelineRuns-consumer",le="0.1"} 13
watcher_workqueue_queue_latency_seconds_bucket{name="PipelineRuns-consumer",le="1"} 21
watcher_workqueue_queue_latency_seconds_bucket{name="PipelineRuns-consumer",le="10"} 38
watcher_workqueue_queue_latency_seconds_bucket{name="PipelineRuns-consumer",le="+Inf"} 38
watcher_workqueue_queue_latency_seconds_sum{name="PipelineRuns-consumer"} 80.84813049999998
watcher_workqueue_queue_latency_seconds_count{name="PipelineRuns-consumer"} 38
watcher_workqueue_queue_latency_seconds_bucket{name="PipelineRuns-fast",le="1e-08"} 0
watcher_workqueue_queue_latency_seconds_bucket{name="PipelineRuns-fast",le="1e-07"} 0
watcher_workqueue_queue_latency_seconds_bucket{name="PipelineRuns-fast",le="1e-06"} 0
watcher_workqueue_queue_latency_seconds_bucket{name="PipelineRuns-fast",le="9.999999999999999e-06"} 39
watcher_workqueue_queue_latency_seconds_bucket{name="PipelineRuns-fast",le="9.999999999999999e-05"} 53
watcher_workqueue_queue_latency_seconds_bucket{name="PipelineRuns-fast",le="0.001"} 54
watcher_workqueue_queue_latency_seconds_bucket{name="PipelineRuns-fast",le="0.01"} 54
watcher_workqueue_queue_latency_seconds_bucket{name="PipelineRuns-fast",le="0.1"} 54
watcher_workqueue_queue_latency_seconds_bucket{name="PipelineRuns-fast",le="1"} 54
watcher_workqueue_queue_latency_seconds_bucket{name="PipelineRuns-fast",le="10"} 54
watcher_workqueue_queue_latency_seconds_bucket{name="PipelineRuns-fast",le="+Inf"} 54
watcher_workqueue_queue_latency_seconds_sum{name="PipelineRuns-fast"} 0.0007665
watcher_workqueue_queue_latency_seconds_count{name="PipelineRuns-fast"} 54
watcher_workqueue_queue_latency_seconds_bucket{name="TaskRuns-consumer",le="1e-08"} 0
watcher_workqueue_queue_latency_seconds_bucket{name="TaskRuns-consumer",le="1e-07"} 0
watcher_workqueue_queue_latency_seconds_bucket{name="TaskRuns-consumer",le="1e-06"} 0
watcher_workqueue_queue_latency_seconds_bucket{name="TaskRuns-consumer",le="9.999999999999999e-06"} 12
watcher_workqueue_queue_latency_seconds_bucket{name="TaskRuns-consumer",le="9.999999999999999e-05"} 15
watcher_workqueue_queue_latency_seconds_bucket{name="TaskRuns-consumer",le="0.001"} 16
watcher_workqueue_queue_latency_seconds_bucket{name="TaskRuns-consumer",le="0.01"} 16
watcher_workqueue_queue_latency_seconds_bucket{name="TaskRuns-consumer",le="0.1"} 16
watcher_workqueue_queue_latency_seconds_bucket{name="TaskRuns-consumer",le="1"} 18
watcher_workqueue_queue_latency_seconds_bucket{name="TaskRuns-consumer",le="10"} 32
watcher_workqueue_queue_latency_seconds_bucket{name="TaskRuns-consumer",le="+Inf"} 61
watcher_workqueue_queue_latency_seconds_sum{name="TaskRuns-consumer"} 530.1455495
watcher_workqueue_queue_latency_seconds_count{name="TaskRuns-consumer"} 61
watcher_workqueue_queue_latency_seconds_bucket{name="TaskRuns-fast",le="1e-08"} 0
watcher_workqueue_queue_latency_seconds_bucket{name="TaskRuns-fast",le="1e-07"} 0
watcher_workqueue_queue_latency_seconds_bucket{name="TaskRuns-fast",le="1e-06"} 0
watcher_workqueue_queue_latency_seconds_bucket{name="TaskRuns-fast",le="9.999999999999999e-06"} 119
watcher_workqueue_queue_latency_seconds_bucket{name="TaskRuns-fast",le="9.999999999999999e-05"} 163
watcher_workqueue_queue_latency_seconds_bucket{name="TaskRuns-fast",le="0.001"} 164
watcher_workqueue_queue_latency_seconds_bucket{name="TaskRuns-fast",le="0.01"} 164
watcher_workqueue_queue_latency_seconds_bucket{name="TaskRuns-fast",le="0.1"} 164
watcher_workqueue_queue_latency_seconds_bucket{name="TaskRuns-fast",le="1"} 164
watcher_workqueue_queue_latency_seconds_bucket{name="TaskRuns-fast",le="10"} 164
watcher_workqueue_queue_latency_seconds_bucket{name="TaskRuns-fast",le="+Inf"} 164
watcher_workqueue_queue_latency_seconds_sum{name="TaskRuns-fast"} 0.0020740000000000003
watcher_workqueue_queue_latency_seconds_count{name="TaskRuns-fast"} 164
# HELP watcher_workqueue_retries_total Total number of retries handled by workqueue
# TYPE watcher_workqueue_retries_total counter
watcher_workqueue_retries_total{name="PipelineRuns-fast"} 11
watcher_workqueue_retries_total{name="TaskRuns-fast"} 2
# HELP watcher_workqueue_unfinished_work_seconds How long in seconds the outstanding workqueue items have been in flight (total).
# TYPE watcher_workqueue_unfinished_work_seconds histogram
watcher_workqueue_unfinished_work_seconds_bucket{name="PipelineRuns-consumer",le="1e-08"} 2285
watcher_workqueue_unfinished_work_seconds_bucket{name="PipelineRuns-consumer",le="1e-07"} 2285
watcher_workqueue_unfinished_work_seconds_bucket{name="PipelineRuns-consumer",le="1e-06"} 2285
watcher_workqueue_unfinished_work_seconds_bucket{name="PipelineRuns-consumer",le="9.999999999999999e-06"} 2285
watcher_workqueue_unfinished_work_seconds_bucket{name="PipelineRuns-consumer",le="9.999999999999999e-05"} 2285
watcher_workqueue_unfinished_work_seconds_bucket{name="PipelineRuns-consumer",le="0.001"} 2285
watcher_workqueue_unfinished_work_seconds_bucket{name="PipelineRuns-consumer",le="0.01"} 2285
watcher_workqueue_unfinished_work_seconds_bucket{name="PipelineRuns-consumer",le="0.1"} 2286
watcher_workqueue_unfinished_work_seconds_bucket{name="PipelineRuns-consumer",le="1"} 2301
watcher_workqueue_unfinished_work_seconds_bucket{name="PipelineRuns-consumer",le="10"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="PipelineRuns-consumer",le="+Inf"} 2387
watcher_workqueue_unfinished_work_seconds_sum{name="PipelineRuns-consumer"} 251.6805405000002
watcher_workqueue_unfinished_work_seconds_count{name="PipelineRuns-consumer"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="PipelineRuns-fast",le="1e-08"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="PipelineRuns-fast",le="1e-07"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="PipelineRuns-fast",le="1e-06"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="PipelineRuns-fast",le="9.999999999999999e-06"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="PipelineRuns-fast",le="9.999999999999999e-05"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="PipelineRuns-fast",le="0.001"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="PipelineRuns-fast",le="0.01"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="PipelineRuns-fast",le="0.1"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="PipelineRuns-fast",le="1"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="PipelineRuns-fast",le="10"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="PipelineRuns-fast",le="+Inf"} 2387
watcher_workqueue_unfinished_work_seconds_sum{name="PipelineRuns-fast"} 0
watcher_workqueue_unfinished_work_seconds_count{name="PipelineRuns-fast"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="PipelineRuns-slow",le="1e-08"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="PipelineRuns-slow",le="1e-07"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="PipelineRuns-slow",le="1e-06"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="PipelineRuns-slow",le="9.999999999999999e-06"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="PipelineRuns-slow",le="9.999999999999999e-05"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="PipelineRuns-slow",le="0.001"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="PipelineRuns-slow",le="0.01"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="PipelineRuns-slow",le="0.1"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="PipelineRuns-slow",le="1"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="PipelineRuns-slow",le="10"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="PipelineRuns-slow",le="+Inf"} 2387
watcher_workqueue_unfinished_work_seconds_sum{name="PipelineRuns-slow"} 0
watcher_workqueue_unfinished_work_seconds_count{name="PipelineRuns-slow"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="TaskRuns-consumer",le="1e-08"} 2281
watcher_workqueue_unfinished_work_seconds_bucket{name="TaskRuns-consumer",le="1e-07"} 2281
watcher_workqueue_unfinished_work_seconds_bucket{name="TaskRuns-consumer",le="1e-06"} 2281
watcher_workqueue_unfinished_work_seconds_bucket{name="TaskRuns-consumer",le="9.999999999999999e-06"} 2281
watcher_workqueue_unfinished_work_seconds_bucket{name="TaskRuns-consumer",le="9.999999999999999e-05"} 2281
watcher_workqueue_unfinished_work_seconds_bucket{name="TaskRuns-consumer",le="0.001"} 2281
watcher_workqueue_unfinished_work_seconds_bucket{name="TaskRuns-consumer",le="0.01"} 2281
watcher_workqueue_unfinished_work_seconds_bucket{name="TaskRuns-consumer",le="0.1"} 2282
watcher_workqueue_unfinished_work_seconds_bucket{name="TaskRuns-consumer",le="1"} 2293
watcher_workqueue_unfinished_work_seconds_bucket{name="TaskRuns-consumer",le="10"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="TaskRuns-consumer",le="+Inf"} 2387
watcher_workqueue_unfinished_work_seconds_sum{name="TaskRuns-consumer"} 274.1152336000002
watcher_workqueue_unfinished_work_seconds_count{name="TaskRuns-consumer"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="TaskRuns-fast",le="1e-08"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="TaskRuns-fast",le="1e-07"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="TaskRuns-fast",le="1e-06"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="TaskRuns-fast",le="9.999999999999999e-06"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="TaskRuns-fast",le="9.999999999999999e-05"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="TaskRuns-fast",le="0.001"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="TaskRuns-fast",le="0.01"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="TaskRuns-fast",le="0.1"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="TaskRuns-fast",le="1"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="TaskRuns-fast",le="10"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="TaskRuns-fast",le="+Inf"} 2387
watcher_workqueue_unfinished_work_seconds_sum{name="TaskRuns-fast"} 0
watcher_workqueue_unfinished_work_seconds_count{name="TaskRuns-fast"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="TaskRuns-slow",le="1e-08"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="TaskRuns-slow",le="1e-07"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="TaskRuns-slow",le="1e-06"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="TaskRuns-slow",le="9.999999999999999e-06"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="TaskRuns-slow",le="9.999999999999999e-05"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="TaskRuns-slow",le="0.001"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="TaskRuns-slow",le="0.01"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="TaskRuns-slow",le="0.1"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="TaskRuns-slow",le="1"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="TaskRuns-slow",le="10"} 2387
watcher_workqueue_unfinished_work_seconds_bucket{name="TaskRuns-slow",le="+Inf"} 2387
watcher_workqueue_unfinished_work_seconds_sum{name="TaskRuns-slow"} 0
watcher_workqueue_unfinished_work_seconds_count{name="TaskRuns-slow"} 2387
# HELP watcher_workqueue_work_duration_seconds How long in seconds processing an item from workqueue takes.
# TYPE watcher_workqueue_work_duration_seconds histogram
watcher_workqueue_work_duration_seconds_bucket{name="PipelineRuns-consumer",le="1e-08"} 0
watcher_workqueue_work_duration_seconds_bucket{name="PipelineRuns-consumer",le="1e-07"} 0
watcher_workqueue_work_duration_seconds_bucket{name="PipelineRuns-consumer",le="1e-06"} 0
watcher_workqueue_work_duration_seconds_bucket{name="PipelineRuns-consumer",le="9.999999999999999e-06"} 0
watcher_workqueue_work_duration_seconds_bucket{name="PipelineRuns-consumer",le="9.999999999999999e-05"} 0
watcher_workqueue_work_duration_seconds_bucket{name="PipelineRuns-consumer",le="0.001"} 0
watcher_workqueue_work_duration_seconds_bucket{name="PipelineRuns-consumer",le="0.01"} 0
watcher_workqueue_work_duration_seconds_bucket{name="PipelineRuns-consumer",le="0.1"} 2
watcher_workqueue_work_duration_seconds_bucket{name="PipelineRuns-consumer",le="1"} 4
watcher_workqueue_work_duration_seconds_bucket{name="PipelineRuns-consumer",le="10"} 38
watcher_workqueue_work_duration_seconds_bucket{name="PipelineRuns-consumer",le="+Inf"} 38
watcher_workqueue_work_duration_seconds_sum{name="PipelineRuns-consumer"} 91.78859300000002
watcher_workqueue_work_duration_seconds_count{name="PipelineRuns-consumer"} 38
watcher_workqueue_work_duration_seconds_bucket{name="PipelineRuns-fast",le="1e-08"} 0
watcher_workqueue_work_duration_seconds_bucket{name="PipelineRuns-fast",le="1e-07"} 0
watcher_workqueue_work_duration_seconds_bucket{name="PipelineRuns-fast",le="1e-06"} 0
watcher_workqueue_work_duration_seconds_bucket{name="PipelineRuns-fast",le="9.999999999999999e-06"} 47
watcher_workqueue_work_duration_seconds_bucket{name="PipelineRuns-fast",le="9.999999999999999e-05"} 54
watcher_workqueue_work_duration_seconds_bucket{name="PipelineRuns-fast",le="0.001"} 54
watcher_workqueue_work_duration_seconds_bucket{name="PipelineRuns-fast",le="0.01"} 54
watcher_workqueue_work_duration_seconds_bucket{name="PipelineRuns-fast",le="0.1"} 54
watcher_workqueue_work_duration_seconds_bucket{name="PipelineRuns-fast",le="1"} 54
watcher_workqueue_work_duration_seconds_bucket{name="PipelineRuns-fast",le="10"} 54
watcher_workqueue_work_duration_seconds_bucket{name="PipelineRuns-fast",le="+Inf"} 54
watcher_workqueue_work_duration_seconds_sum{name="PipelineRuns-fast"} 0.0004531
watcher_workqueue_work_duration_seconds_count{name="PipelineRuns-fast"} 54
watcher_workqueue_work_duration_seconds_bucket{name="TaskRuns-consumer",le="1e-08"} 0
watcher_workqueue_work_duration_seconds_bucket{name="TaskRuns-consumer",le="1e-07"} 0
watcher_workqueue_work_duration_seconds_bucket{name="TaskRuns-consumer",le="1e-06"} 0
watcher_workqueue_work_duration_seconds_bucket{name="TaskRuns-consumer",le="9.999999999999999e-06"} 0
watcher_workqueue_work_duration_seconds_bucket{name="TaskRuns-consumer",le="9.999999999999999e-05"} 4
watcher_workqueue_work_duration_seconds_bucket{name="TaskRuns-consumer",le="0.001"} 6
watcher_workqueue_work_duration_seconds_bucket{name="TaskRuns-consumer",le="0.01"} 6
watcher_workqueue_work_duration_seconds_bucket{name="TaskRuns-consumer",le="0.1"} 15
watcher_workqueue_work_duration_seconds_bucket{name="TaskRuns-consumer",le="1"} 19
watcher_workqueue_work_duration_seconds_bucket{name="TaskRuns-consumer",le="10"} 61
watcher_workqueue_work_duration_seconds_bucket{name="TaskRuns-consumer",le="+Inf"} 61
watcher_workqueue_work_duration_seconds_sum{name="TaskRuns-consumer"} 105.41452930000003
watcher_workqueue_work_duration_seconds_count{name="TaskRuns-consumer"} 61
watcher_workqueue_work_duration_seconds_bucket{name="TaskRuns-fast",le="1e-08"} 0
watcher_workqueue_work_duration_seconds_bucket{name="TaskRuns-fast",le="1e-07"} 0
watcher_workqueue_work_duration_seconds_bucket{name="TaskRuns-fast",le="1e-06"} 0
watcher_workqueue_work_duration_seconds_bucket{name="TaskRuns-fast",le="9.999999999999999e-06"} 153
watcher_workqueue_work_duration_seconds_bucket{name="TaskRuns-fast",le="9.999999999999999e-05"} 163
watcher_workqueue_work_duration_seconds_bucket{name="TaskRuns-fast",le="0.001"} 164
watcher_workqueue_work_duration_seconds_bucket{name="TaskRuns-fast",le="0.01"} 164
watcher_workqueue_work_duration_seconds_bucket{name="TaskRuns-fast",le="0.1"} 164
watcher_workqueue_work_duration_seconds_bucket{name="TaskRuns-fast",le="1"} 164
watcher_workqueue_work_duration_seconds_bucket{name="TaskRuns-fast",le="10"} 164
watcher_workqueue_work_duration_seconds_bucket{name="TaskRuns-fast",le="+Inf"} 164
watcher_workqueue_work_duration_seconds_sum{name="TaskRuns-fast"} 0.0013376000000000004
watcher_workqueue_work_duration_seconds_count{name="TaskRuns-fast"} 164
sayan-biswas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me other than few cosmetic changes.
Given the size of this feature, we'll probably need reviews from other reviewers.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avinal, enarha, sayan-biswas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I think the PR is ready, just a last cleanup, please merge all the commits into one. |
f25a9b2 to
2ff839f
Compare
|
Squashed. |
|
Is there any thing we are waiting to merge this pr? |
2ff839f to
832fe50
Compare
|
Given @sayan-biswas already spent time on reviewing, lets wait for him to lgtm. IMO this PR has been open for long time and received enough reviews. It's on the bigger side, but it only adds functionality and not changing existing functionality, so it's ready to be merged. |
|
@enarha I have already approved it. Was just checking if we need anyone else to review it. |
|
/lgtm |
Changes
Add delete count and duration metrics for TaskRun and PipelineRun. It helps to take a move on #323
About metrics config:
metrics.taskrun.leveldoes not provideTaskrunLevelAtTaskrunoption andmetrics.pipelinerun.leveldoes not providePipelinerunLevelAtPipelinrrun, because these two options are too atomic for metrics and generate too much metrics./kind feature
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes