Skip to content

Set go to 1.23 for GolangCILint job #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tekton-robot merged 1 commit into from
Feb 19, 2025
Merged

Set go to 1.23 for GolangCILint job #971

tekton-robot merged 1 commit into from
Feb 19, 2025

Conversation

@khrm
Copy link
Contributor

@khrm khrm commented Feb 19, 2025 •
edited
Loading

Stable means 1.24 now. This explicitly set it to 1.23

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Tested your changes locally (if this is a code change)
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@khrm
Set go to 1.23 for GolangCILint job
b9c414c 
Stable means 1.24 now. This explicitly set it to 1.23
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 19, 2025
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesnt merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 19, 2025
khrm
khrm commented Feb 19, 2025
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Feb 19, 2025
@khrm
Copy link
Contributor Author

khrm commented Feb 19, 2025

/assign @vdemeester @enarha

vdemeester
vdemeester approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2025
@tekton-robot
Copy link

tekton-robot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2025
@tekton-robot tekton-robot merged commit e49eb8f into main Feb 19, 2025
7 checks passed
@khrm khrm deleted the khrm-patch-3 branch February 19, 2025 06:20
@khrm
Copy link
Contributor Author

khrm commented Feb 19, 2025

/cherry-pick release-v0.14.x

@tekton-robot
Copy link

tekton-robot commented Feb 19, 2025

@khrm: new pull request created: #975

Details

In response to this:

/cherry-pick release-v0.14.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdemeester vdemeester vdemeester approved these changes

@avinal avinal Awaiting requested review from avinal

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@vdemeester vdemeester

@enarha enarha

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@khrm @tekton-robot @vdemeester @enarha