Skip to content

[CLI enchancement] Refactor directory structure for the enhanced CLI #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tekton-robot merged 1 commit into from
Apr 1, 2025
Merged

[CLI enchancement] Refactor directory structure for the enhanced CLI #983

tekton-robot merged 1 commit into from
Apr 1, 2025

Conversation

@divyansh42
Copy link
Member

@divyansh42 divyansh42 commented Mar 17, 2025 •
edited
Loading

Changes

These changes are related to tektoncd/community#1179
Modified the directory structure so that code for the enhanced CLI can be properly placed without changing the existing functionalities.
Once the enhanced CLI is ready to use, we should add a deprecated message to the existing commands and advise users to use the new commands. As of now, there is no plan to remove these commands as those can be handy for debugging purposes.

/kind misc
/release-note-none

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Tested your changes locally (if this is a code change)
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

@divyansh42
Refactor directory structure for the enhanced CLI
6298128 
Signed-off-by: divyansh42 <diagrawa@redhat.com>
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/misc Categorizes issue or PR as a miscellaneuous one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 17, 2025
@tekton-robot tekton-robot requested review from enarha and khrm March 17, 2025 06:42
@divyansh42 divyansh42 mentioned this pull request Mar 17, 2025
Closed
8 tasks
@tekton-robot
Copy link

tekton-robot commented Mar 17, 2025

The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cli/dev/client/client.go Do not exist 15.0%
pkg/cli/dev/cmd/logs/get.go Do not exist 0.0%
pkg/cli/dev/cmd/logs/list.go Do not exist 0.0%
pkg/cli/dev/cmd/logs/logs.go Do not exist 0.0%
pkg/cli/dev/cmd/pipelinerun/list.go Do not exist 69.4%
pkg/cli/dev/cmd/pipelinerun/pipelinerun.go Do not exist 100.0%
pkg/cli/dev/cmd/records/get.go Do not exist 0.0%
pkg/cli/dev/cmd/records/list.go Do not exist 0.0%
pkg/cli/dev/cmd/records/records.go Do not exist 0.0%
pkg/cli/dev/cmd/result/describe.go Do not exist 64.3%
pkg/cli/dev/cmd/result/list.go Do not exist 40.0%
pkg/cli/dev/cmd/result/result.go Do not exist 100.0%
pkg/cli/dev/config/config.go Do not exist 48.3%
pkg/cli/dev/flags/flags.go Do not exist 0.0%
pkg/cli/dev/format/format.go Do not exist 0.0%
pkg/cli/dev/portforward/portforward.go Do not exist 0.0%

@divyansh42
Copy link
Member Author

divyansh42 commented Mar 17, 2025

/test pull-tekton-results-unit-tests

@enarha
Copy link
Contributor

enarha commented Mar 31, 2025

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2025
avinal
avinal approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member

@avinal avinal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me
/lgtm
/approve

@tekton-robot
Copy link

tekton-robot commented Apr 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avinal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2025
@tekton-robot tekton-robot merged commit 22ab770 into tektoncd:main Apr 1, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avinal avinal avinal approved these changes

@enarha enarha Awaiting requested review from enarha

@khrm khrm Awaiting requested review from khrm

Assignees

@enarha enarha

@avinal avinal

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@divyansh42 @tekton-robot @enarha @avinal