[CLI] Revert record get command template changes
#1044
Conversation
Reverting the template added to the record get command as it is a breaking change of the existing users who are using the CLI in the automation scripts It was through PR tektoncd#908 Signed-off-by: divyansh42 <diagrawa@redhat.com>
|
/hold |
There was a problem hiding this comment.
Pull Request Overview
Revert the previous template-based output for the record get command to avoid breaking existing automation scripts.
- Restore default output by replacing custom
formatRecordlogic withformat.PrintProto. - Remove unused imports and the custom template/function definitions.
- Update
GetRecordCommandto callPrintProtoon the RPC response.
Comments suppressed due to low confidence (2)
pkg/cli/dev/cmd/records/get.go:36
- [nitpick] The variable name
respis generic—consider renaming it torecordorresultto more clearly reflect that it holds aRecordresource.
resp, err := params.ResultsClient.GetRecord(cmd.Context(), &pb.GetRecordRequest{
pkg/cli/dev/cmd/records/get.go:43
- Add a unit or integration test to verify that
format.PrintProtoon the record response produces the expected output formats (JSON, YAML, etc.).
return format.PrintProto(os.Stdout, resp, opts.Format)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khrm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-v0.15.x |
|
@khrm: once the present PR merges, I will cherry-pick it on top of release-v0.15.x in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
record get command template changes
|
/hold cancel |
|
/hold cancel |
|
/lgtm |
|
@khrm: new pull request created: #1045 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
Reverting the template added to the record get command as it is a breaking change of the existing users who are using the CLI in the automation scripts
It was through PR #908
Here are the details: f37d74e#diff-824650fc9b46e72f0d1a957f97776b5cf8c3d9b7ee925d3ac71d844dde6b4da5
/kind bug
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes