Add support for fine-grained retention policies #1077

khrm · 2025-08-03T23:08:17Z

This allows defining multiple retention policies based on selectors like namespace, labels, and status, providing more granular control over result retention.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Has Docs included if any changes are user facing
Has Tests included if any functionality added or changed
Tested your changes locally (if this is a code change)
Follows the commit message standard
Meets the Tekton contributor standards (including functionality, content, code)
Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Tekton Results now supports fine-grained retention policies, allowing you to set different retention periods for `PipelineRun` and top-level `TaskRun` results based on their **namespace, labels, annotations, and status**.

This provides granular control to balance storage costs with compliance and debugging needs. The first policy that a result matches is applied. If no policy matches, the result falls back to the default `maxRetention` period.

The feature is configured by adding a `policies` key to the `tekton-results-config-results-retention-policy` `ConfigMap`.

khrm · 2025-08-03T23:09:05Z

/kind feature

tekton-robot · 2025-08-03T23:14:23Z

The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/retention.go	10.5%	65.6%	55.1
pkg/retention/job.go	38.9%	58.3%	19.4

khrm · 2025-08-04T00:03:28Z

/test pull-tekton-results-build-tests

khrm · 2025-08-04T00:04:00Z

/assign @enarha

tekton-robot · 2025-08-04T00:06:29Z

@khrm: GitHub didn't allow me to assign the following users: andrewpthorp.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign @andrewpthorp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot · 2025-08-04T00:07:59Z

The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/retention.go	10.5%	65.6%	55.1
pkg/retention/job.go	38.9%	56.0%	17.1

khrm · 2025-08-04T00:08:51Z

/assign @aThorp96

tekton-robot · 2025-08-04T00:08:53Z

@khrm: GitHub didn't allow me to assign the following users: aThorp96.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign @aThorp96

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

khrm · 2025-08-04T00:31:35Z

/test pull-tekton-results-build-tests

aThorp96

Haven't looked through the code yet, but had some requests regarding the design of the feature's configuration

docs/retention-policy-agent/README.md

tekton-robot · 2025-08-10T05:02:47Z

The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/retention.go	10.5%	65.6%	55.1
pkg/retention/job.go	38.9%	56.0%	17.1

khrm · 2025-08-10T05:28:19Z

I have updated the documentation to clarify that omitting a selector type means it matches all results for that criterion.

This allows defining multiple retention policies based on selectors like namespace, labels, and status, providing more granular control over result retention. Assisted By: Gemini

khrm · 2025-08-10T05:29:29Z

/test pull-tekton-results-build-tests

khrm · 2025-08-10T05:33:06Z

@enarha Can you re-review this?

tekton-robot · 2025-08-10T05:33:23Z

The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/retention.go	10.5%	65.6%	55.1
pkg/retention/job.go	38.9%	56.0%	17.1

enarha · 2025-08-10T05:45:11Z

/lgtm

khrm · 2025-08-11T04:59:49Z

@aThorp96 @enarha Let's merge this. We want to do a release of results today.

khrm · 2025-08-11T15:58:19Z

@aThorp96 Can you please take a look?

docs/retention-policy-agent/README.md

pkg/retention/job.go

tekton-robot · 2025-08-11T19:18:18Z

The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/retention.go	10.5%	39.7%	29.2
pkg/retention/job.go	38.9%	56.0%	17.1

aThorp96

/lgtm

Thanks @khrm

pkg/apis/config/retention.go

tekton-robot · 2025-08-11T19:21:10Z

@aThorp96: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Thanks @khrm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Deprecates the `maxRetention` field in the retention policy configuration and replaces it with `defaultRetention`. For backward compatibility, if `defaultRetention` is not specified, the value of `maxRetention` will be used. Also updated the `DeepCopy` function for `RetentionPolicy` to correctly perform a deep copy of the `Policies` slice and its nested fields.

tekton-robot · 2025-08-11T19:27:06Z

The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/retention.go	10.5%	40.6%	30.1
pkg/retention/job.go	38.9%	56.0%	17.1

aThorp96

/lgtm

tekton-robot · 2025-08-11T19:35:47Z

@aThorp96: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

enarha · 2025-08-12T07:08:44Z

/approve

tekton-robot · 2025-08-12T07:08:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aThorp96, enarha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [enarha]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

khrm · 2025-08-12T07:26:44Z

@enarha Can you give lgtm also? It was removed after last changes.

khrm · 2025-08-12T07:32:09Z

@enarha Can you give lgtm here? Andrew is restricted from it.

enarha · 2025-08-12T09:00:40Z

/lgtm

tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 3, 2025

tekton-robot requested review from alan-ghelardi and avinal August 3, 2025 23:08

tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 3, 2025

tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 3, 2025

khrm force-pushed the f/ret-pol branch 2 times, most recently from 94685a2 to 5b85f7b Compare August 4, 2025 00:03

tekton-robot assigned enarha Aug 4, 2025

tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels Aug 4, 2025

khrm changed the title ~~feat(retention): Add support for fine-grained retention policies~~ Add support for fine-grained retention policies Aug 4, 2025

khrm unassigned enarha Aug 4, 2025

khrm assigned enarha Aug 4, 2025

aThorp96 reviewed Aug 4, 2025

View reviewed changes

docs/retention-policy-agent/README.md Outdated Show resolved Hide resolved

docs/retention-policy-agent/README.md Show resolved Hide resolved

docs/retention-policy-agent/README.md Outdated Show resolved Hide resolved

docs/retention-policy-agent/README.md Outdated Show resolved Hide resolved

enarha reviewed Aug 4, 2025

View reviewed changes

docs/retention-policy-agent/README.md Outdated Show resolved Hide resolved

docs/retention-policy-agent/README.md Outdated Show resolved Hide resolved

docs/retention-policy-agent/README.md Outdated Show resolved Hide resolved

khrm force-pushed the f/ret-pol branch from 5b85f7b to 98f873c Compare August 10, 2025 04:58

Add support for fine-grained retention policies

c682db7

This allows defining multiple retention policies based on selectors like namespace, labels, and status, providing more granular control over result retention. Assisted By: Gemini

khrm force-pushed the f/ret-pol branch from 98f873c to c682db7 Compare August 10, 2025 05:29

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2025

aThorp96 reviewed Aug 11, 2025

View reviewed changes

docs/retention-policy-agent/README.md Outdated Show resolved Hide resolved

aThorp96 reviewed Aug 11, 2025

View reviewed changes

pkg/retention/job.go Show resolved Hide resolved

tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2025

khrm force-pushed the f/ret-pol branch from d1b3467 to 542d81f Compare August 11, 2025 19:13

aThorp96 approved these changes Aug 11, 2025

View reviewed changes

pkg/apis/config/retention.go Outdated Show resolved Hide resolved

khrm force-pushed the f/ret-pol branch from 542d81f to 31847a5 Compare August 11, 2025 19:22

aThorp96 approved these changes Aug 11, 2025

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2025

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2025

tekton-robot merged commit b358b2d into tektoncd:main Aug 12, 2025
9 checks passed

Add support for fine-grained retention policies #1077

Add support for fine-grained retention policies #1077

Uh oh!

Conversation

khrm commented Aug 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Submitter Checklist

Release Notes

Uh oh!

khrm commented Aug 3, 2025

Uh oh!

tekton-robot commented Aug 3, 2025

Uh oh!

khrm commented Aug 4, 2025

Uh oh!

khrm commented Aug 4, 2025

Uh oh!

tekton-robot commented Aug 4, 2025

Uh oh!

tekton-robot commented Aug 4, 2025

Uh oh!

khrm commented Aug 4, 2025

Uh oh!

tekton-robot commented Aug 4, 2025

Uh oh!

khrm commented Aug 4, 2025

Uh oh!

aThorp96 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tekton-robot commented Aug 10, 2025

Uh oh!

khrm commented Aug 10, 2025

Uh oh!

khrm commented Aug 10, 2025

Uh oh!

khrm commented Aug 10, 2025

Uh oh!

tekton-robot commented Aug 10, 2025

Uh oh!

enarha commented Aug 10, 2025

Uh oh!

khrm commented Aug 11, 2025

Uh oh!

khrm commented Aug 11, 2025

Uh oh!

Uh oh!

Uh oh!

tekton-robot commented Aug 11, 2025

Uh oh!

aThorp96 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tekton-robot commented Aug 11, 2025

Uh oh!

tekton-robot commented Aug 11, 2025

Uh oh!

aThorp96 left a comment

Choose a reason for hiding this comment

Uh oh!

tekton-robot commented Aug 11, 2025

Uh oh!

enarha commented Aug 12, 2025

Uh oh!

tekton-robot commented Aug 12, 2025

Uh oh!

khrm commented Aug 12, 2025

Uh oh!

khrm commented Aug 12, 2025

Uh oh!

enarha commented Aug 12, 2025

khrm commented Aug 3, 2025 •

edited

Loading