Skip to content

Conversation

@alan-ghelardi
Copy link
Contributor

What

This pull request resolves #254. The
following fixes and improvements were made:

  • Fix object deletion upon completion: apparently, the main cause of the
    instability was the use of the record to determine the time at which the Run
    object had been updated. I changed the watcher to use the
    Status.CompletionTime since this approach seems to be more
    reliable. Currently, if the Tekton
    pipelines controller resyncs the object and transitions the status, the object
    will change, the record will be updated and this will cause discrepancies in the
    verification of the grace period expiration.
  • The aforementioned change fixes end-to-end tests. Now, the test suite is
    passing consistently in my machine (this
    pr should be merged as well
    since it fixes other issues in the current e2e setup).
  • Improve logs emitted by the watcher: favor structured logging since it
    simplifies a lot the debugging with log indexer tools such as Splunk and others.
  • Refactor the controller's code to make it simpler and hopefully, easier to
    reason about. I tried to make things more uniform and meaningful for new
    collaborators. One of the most relevant changes was removing the enqueue
    function that was being passed around and replacing the approach with the
    knative's controller.NewRequeueAfter function which returns an error that
    tells knative to requeue the key after a given duration.

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 18, 2022
@alan-ghelardi
Copy link
Contributor Author

/assign @vdemeester

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2022
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khrm, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dibyom
Copy link
Member

dibyom commented Oct 26, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2022
@tekton-robot tekton-robot merged commit 5aba48e into tektoncd:main Oct 26, 2022
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind bug
We need this label for release as discussed in the last WG call.

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Object deletion isn't working properly and E2E tests are broken

5 participants