Fix resource deletion and refactor watcher #255
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This pull request resolves #254. The
following fixes and improvements were made:
instability was the use of the record to determine the time at which the Run
object had been updated. I changed the watcher to use the
Status.CompletionTimesince this approach seems to be morereliable. Currently, if the Tekton
pipelines controller resyncs the object and transitions the status, the object
will change, the record will be updated and this will cause discrepancies in the
verification of the grace period expiration.
passing consistently in my machine (this
pr should be merged as well
since it fixes other issues in the current e2e setup).
simplifies a lot the debugging with log indexer tools such as Splunk and others.
reason about. I tried to make things more uniform and meaningful for new
collaborators. One of the most relevant changes was removing the enqueue
function that was being passed around and replacing the approach with the
knative's
controller.NewRequeueAfterfunction which returns an error thattells knative to requeue the key after a given duration.