Skip to content

Support gRPC binary metadata headers in C bridge #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmaeagle99 merged 6 commits into from
Dec 12, 2025
Merged

Support gRPC binary metadata headers in C bridge #1076

jmaeagle99 merged 6 commits into from
Dec 12, 2025

Conversation

@jmaeagle99
Copy link
Contributor

@jmaeagle99 jmaeagle99 commented Dec 10, 2025

What was changed

  • Added support for binary metadata headers for gRPC calls in the C bridge
  • Unified the data format used for ASCII headers and binary headers to use GrpcMetadataRef across the C bridge.
  • Added a test to validate that ascii and binary headers are properly passed to the RPC handler.

Why?

Tonic will return errors if binary headers are passed in as ASCII headers. Add support for passing binary headers and ensure they are combined together appropriately for gRPC requests.

Checklist

  1. Closes [Feature Request] Ensure gRPC binary metadata headers are supported in C bridge #991

  2. How was this tested: Add tests to verify header passing

  3. Any docs updates needed? Not sure

@jmaeagle99 jmaeagle99 requested a review from a team as a code owner December 10, 2025 00:08
jmaeagle99
jmaeagle99 commented Dec 10, 2025
View reviewed changes
jmaeagle99
jmaeagle99 commented Dec 10, 2025
View reviewed changes
cretz
cretz reviewed Dec 10, 2025
View reviewed changes
cretz
cretz reviewed Dec 10, 2025
View reviewed changes
cretz
cretz approved these changes Dec 10, 2025
View reviewed changes
Copy link
Member

@cretz cretz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, but may want @Sushisource's approval before merging. Also, could develop the .NET SDK aspect with your branch as the submodule to confirm this does what is needed before merging.

Sushisource
Sushisource approved these changes Dec 10, 2025
View reviewed changes
Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me!

@jmaeagle99
Copy link
Contributor Author

jmaeagle99 commented Dec 10, 2025

Looks great to me, but may want @Sushisource's approval before merging. Also, could develop the .NET SDK aspect with your branch as the submodule to confirm this does what is needed before merging.

Absolutely, working on that now and will confirm before merging.

@jmaeagle99
Copy link
Contributor Author

jmaeagle99 commented Dec 10, 2025

Looks great to me, but may want @Sushisource's approval before merging. Also, could develop the .NET SDK aspect with your branch as the submodule to confirm this does what is needed before merging.

Absolutely, working on that now and will confirm before merging.

I will wait for temporalio/sdk-dotnet#570 to be completed as there would be duplicated effort to adjust to sdk-core and library changes.

@jmaeagle99 jmaeagle99 mentioned this pull request Dec 12, 2025
Merged
@jmaeagle99 jmaeagle99 enabled auto-merge (squash) December 12, 2025 21:36
@jmaeagle99 jmaeagle99 merged commit 43d582b into temporalio:master Dec 12, 2025
19 checks passed
@jmaeagle99 jmaeagle99 deleted the bin-headers branch December 12, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cretz cretz cretz approved these changes

@Sushisource Sushisource Sushisource approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request] Ensure gRPC binary metadata headers are supported in C bridge

3 participants

@jmaeagle99 @cretz @Sushisource