fix: locale for both dev=True/False #2010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keming <kemingyang@tensorchord.ai>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts locale settings to use C.UTF-8 across the codebase, reverts previous en_US.UTF-8 settings, and updates the default miniconda version.
- Change locale variables from en_US.UTF-8 to C.UTF-8 in environment setup
- Remove the locale-gen command from the apt installation flow to align with the new locale setting
- Update the default miniconda version in the conda configuration
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/types/envd.go | Updated LANG and LC_ALL values to maintain consistent locale usage |
| pkg/lang/ir/v1/system.go | Removed the locale-gen command to avoid generating en_US.UTF-8 |
| pkg/lang/ir/v1/conda.go | Updated condaVersionDefault for a newer miniconda version |
| pkg/lang/ir/v1/compile.go | Adjusted LC_ALL environment variable to match the new locale |
Files not reviewed (1)
- pkg/lang/ir/v1/get_conda.sh: Language not supported
Member
Author
|
gaocegege
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
starshipfor prompt