Add random_state for non negative PARAFAC HALS #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #344 +/- ##
=======================================
Coverage 88.19% 88.19%
=======================================
Files 103 103
Lines 5996 5997 +1
=======================================
+ Hits 5288 5289 +1
Misses 708 708
Continue to review full report at Codecov.
|
Member
|
Thanks @MarieRoald, great to have this! |
Member
|
Thanks @MarieRoald, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
non_negative_parafac_halsandNN_PARAFAC_HALSdo not support a random seed. If random initialisation is used, then the random state is set to None. This pull requests fixes that, and adds arandom_stateargument.