Make tl.shape return tuple for PyTorch backend
#357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #357 +/- ##
=======================================
Coverage 88.16% 88.16%
=======================================
Files 105 105
Lines 6058 6058
=======================================
Hits 5341 5341
Misses 717 717
Continue to review full report at Codecov.
|
cohenjer
approved these changes
Feb 1, 2022
Contributor
cohenjer
left a comment
There was a problem hiding this comment.
Seems very reasonable to me !
Member
|
Thanks @MarieRoald, looks good to me too, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
tl.shapereturns a tuple for most backends. However, with the PyTorch backend, it returns atorch.Sizeobject, which can make it more difficult to make backend agnostic code. This pull request makes it return a tuple instead and adds a test that fails if the object returned fromtl.shapeis not atuple.Alternatively, if we don't want to cast the
torch.Sizeto a tuple automatically, then we could add an optionalas_tupleargument to all backends. However, I made it cast to a tuple since that is what's done in the TensorFlow backend.