Skip to content

Conversation

@aarmey
Copy link
Contributor

@aarmey aarmey commented Sep 23, 2022

The docs stopped building due to a change in the behavior of matplotlib (issue #23973).

I am proposing to pin the version of matplotlib so that we can ensure reproducible behavior. We can certainly update the plotting code in the documentation to work with the most recent version; this fix additionally prevents similar situations in the future.

@cyrillustan

@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Merging #450 (fed449d) into main (a628f79) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #450      +/-   ##
==========================================
+ Coverage   88.76%   88.78%   +0.02%     
==========================================
  Files         111      107       -4     
  Lines        6648     6340     -308     
==========================================
- Hits         5901     5629     -272     
+ Misses        747      711      -36     
Impacted Files Coverage Δ
tensorly/decomposition/_cmtf_als.py 90.90% <0.00%> (-3.04%) ⬇️
tensorly/decomposition/__init__.py
tensorly/__init__.py
tensorly/cp_tensor.py
tensorly/base.py
tensorly/tenalg/proximal.py 67.68% <0.00%> (+0.23%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aarmey aarmey requested a review from JeanKossaifi September 23, 2022 20:24
@aarmey aarmey added the bug label Sep 23, 2022
@aarmey aarmey merged commit db1eb97 into main Sep 25, 2022
@aarmey aarmey deleted the fix-docs branch September 25, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants